Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve basic button and label styles #14119

Merged
merged 8 commits into from
Dec 27, 2020
Merged

Improve basic button and label styles #14119

merged 8 commits into from
Dec 27, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 22, 2020 •
edited
Loading

  • Simplify disabled styling of label by matching for the disabled attribute.
  • Raise fomantic disabled opacity from .45 to .55 to for more contrast.
  • Use CSS vars for basic button styles.
  • Consolidate basic label and button styles.

Screen Shot 2020-12-24 at 12 33 12

Screen Shot 2020-12-24 at 12 33 30

Screen Shot 2020-12-24 at 12 33 18

Screen Shot 2020-12-24 at 12 33 36

Screen Shot 2020-12-24 at 12 33 50

Screen Shot 2020-12-24 at 12 34 02

@silverwind silverwind added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 22, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 22, 2020
@silverwind silverwind force-pushed the csstweaks18 branch 2 times, most recently from d115cde to 5f15004 Compare December 22, 2020 23:42
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 23, 2020
@silverwind
Copy link
Member Author

silverwind commented Dec 23, 2020 •
edited
Loading

I think I'll do another rework of the colors in use here so that labels and basic buttons get to use the same color variables for hover and active states.

@silverwind silverwind marked this pull request as draft December 23, 2020 19:17
@silverwind silverwind marked this pull request as ready for review December 24, 2020 11:36
@silverwind
Copy link
Member Author

silverwind commented Dec 24, 2020 •
edited
Loading

Vars consolidation done. Basic labels and basic buttons now use the exact same color in all their states. Also applied these colors to the unsigned commit labels. Screenshots updated.

@silverwind silverwind changed the title Improve disabled styles for repo buttons Improve basic button and label styles Dec 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2020
@lafriks
Copy link
Member

lafriks commented Dec 27, 2020

conflicts

@silverwind
Improve disabled styles for repo buttons
392c6d3 
- Simplify disabled styling of label by matching for the disabled
  attribute.
- Raise fomantic disabled opacity from .45 to .55 to for more contrast.
- Use CSS vars for basic button styles.
@silverwind
restore clickability on label
a972c72
@silverwind
color tweaks and remove arc-green style
9a8a09a
@silverwind
slightly reduce button size
cd42c06
@silverwind
consolidate vars
4a46231
@silverwind
also cover active class
678bb27
@silverwind
slightly more distinct active class
8023490
@silverwind
remove useless rule
0714ff7
@silverwind
Copy link
Member Author

rebased

@lunny lunny merged commit fe40372 into go-gitea:master Dec 27, 2020
@silverwind silverwind deleted the csstweaks18 branch December 27, 2020 10:54
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lafriks @lunny @GiteaBot