Fix bug of link query order on markdown render #14156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noerw
approved these changes
Dec 27, 2020
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Dec 27, 2020
GiteaBot
added
lgtm/done
|
@lunny need to change tests: |
|
no - don't change the tests - fix the query parameter it's not escaping properly. |
6543
added
the
status/blocked
lunny
force-pushed
the
lunny/fix_urls
branch
from
e8b65f9
to
e67dd5c
Compare
|
The first test should be right and I changed the bluemonday codes. I also changed the second test on this PR because it should be a wrong test. html_test.go:143
Error: Not equal:
expected: "<p><a href=\"magnet:?dn=download&xt=urn%3Abtih%3A5dee65101db281ac9c46344cd6b175cdcadabcde\" rel=\"nofollow\">magnet:?xt=urn:btih:5dee65101db281ac9c46344cd6b175cdcadabcde&dn=download</a></p>"
actual : "<p><a href=\"magnet:?xt=urn:btih:5dee65101db281ac9c46344cd6b175cdcadabcde&dn=download\" rel=\"nofollow\">magnet:?xt=urn:btih:5dee65101db281ac9c46344cd6b175cdcadabcde&dn=download</a></p>"
Diff:
--- Expected
+++ Actual
@@ -1 +1 @@
-<p><a href="magnet:?dn=download&xt=urn%3Abtih%3A5dee65101db281ac9c46344cd6b175cdcadabcde" rel="nofollow">magnet:?xt=urn:btih:5dee65101db281ac9c46344cd6b175cdcadabcde&dn=download</a></p>
+<p><a href="magnet:?xt=urn:btih:5dee65101db281ac9c46344cd6b175cdcadabcde&dn=download" rel="nofollow">magnet:?xt=urn:btih:5dee65101db281ac9c46344cd6b175cdcadabcde&dn=download</a></p>
Test: TestRender_linksIt's obvious, the query order changed but should not. |
Codecov Report
@@ Coverage Diff @@
## master #14156 +/- ##
==========================================
- Coverage 42.36% 42.02% -0.34%
==========================================
Files 728 733 +5
Lines 78015 78666 +651
==========================================
+ Hits 33049 33059 +10
- Misses 39540 40179 +639
- Partials 5426 5428 +2
Continue to review full report at Codecov.
|
6543
removed
the
status/blocked
zeripath
reviewed
Dec 27, 2020
zeripath
approved these changes
Dec 28, 2020
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Dec 28, 2020
* Fix bug of link query order on markdown render * Fix bluemonday bug and fix one wrong test Co-authored-by: 6543 <6543@obermui.de>
techknowlogick
pushed a commit
that referenced
this pull request
Dec 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #14090
We temporarily use a replace on go.mod before microcosm-cc/bluemonday#105 merged.