Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imprufe router related code #14486

Closed
1 task
6543 opened this issue Jan 27, 2021 · 2 comments
Closed
1 task

Imprufe router related code #14486

6543 opened this issue Jan 27, 2021 · 2 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail performance/memory Performance issues affecting memory use performance/speed performance issues with slow downs type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@6543
Copy link
Member

6543 commented Jan 27, 2021

Since we moved to chi, we do not have dependency to macaron anymore ... ( @zeripath you talked about some "cant do because of macaron...", can you describe these if you remember?)

also we do use context package more heavily, we should have a look what we could optimize there.

@6543 6543 added type/proposal The new feature has not been accepted yet but needs to be discussed first. performance/speed performance issues with slow downs performance/memory Performance issues affecting memory use labels Jan 27, 2021
@wxiaoguang
Copy link
Contributor

Our route code has been hugely refactored by #24080 , I think there won't be blockers, we are on our own way.

So this issue could be closed?

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 26, 2023
@6543
Copy link
Member Author

6543 commented Apr 30, 2023

yes we finaly got dir of that

@6543 6543 closed this as completed Apr 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail performance/memory Performance issues affecting memory use performance/speed performance issues with slow downs type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants