Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate WatchInfo struct to api #1492

Merged
merged 3 commits into from
Apr 16, 2017
Merged

Migrate WatchInfo struct to api #1492

merged 3 commits into from
Apr 16, 2017

Conversation

sapk
Copy link
Member

@sapk sapk commented Apr 14, 2017

So that the api repo contain all struct for api response and resquest.

Need : go-gitea/go-sdk#50

@lunny lunny added this to the 1.2.0 milestone Apr 14, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 14, 2017
@sapk sapk changed the title [WIP] Migrate WatchInfo struct to api Migrate WatchInfo struct to api Apr 14, 2017
@sapk
Copy link
Member Author

sapk commented Apr 14, 2017

This is ready just need go-gitea/go-sdk#50 so I will update govendor when merged.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 14, 2017
@appleboy
Copy link
Member

@sapk Please go ahead.

@sapk
Copy link
Member Author

sapk commented Apr 15, 2017

go-gitea/go-sdk#50 is merged.
I remove temporary change in vendor and this is ok to be review/merged.

@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 15, 2017
@lunny
Copy link
Member

lunny commented Apr 16, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 16, 2017
@appleboy appleboy merged commit cf91cfb into go-gitea:master Apr 16, 2017
@sapk sapk deleted the migrate-watchinfo branch April 28, 2017 10:03
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sapk @appleboy @lunny @tboerger