Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Labels & IssueLabels on Repo Delete too #15039

Merged
merged 13 commits into from
Mar 19, 2021
Merged

Delete Labels & IssueLabels on Repo Delete too #15039

merged 13 commits into from
Mar 19, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 19, 2021

close #15036

@6543 6543 added this to the 1.14.0 milestone Mar 19, 2021
6543
6543 commented Mar 19, 2021
View reviewed changes
models/issue_label.go Outdated Show resolved Hide resolved
models/repo.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2021
6543
6543 commented Mar 19, 2021
View reviewed changes
models/consistency.go Outdated Show resolved Hide resolved
models/repo.go Show resolved Hide resolved
zeripath
zeripath reviewed Mar 19, 2021
View reviewed changes
models/migrations/v176.go Outdated Show resolved Hide resolved
@6543
Copy link
Member Author

6543 commented Mar 19, 2021

@zeripath this is just the SQL query converted from builder into raw SQL ... + an AS ... witch worked on my PC too

@lafriks
Copy link
Member

lafriks commented Mar 19, 2021

MySQL migrations fail with:

Unknown column 'conflicted_files' in 'field list'

6543
6543 commented Mar 19, 2021
View reviewed changes
models/migrations/v176.go Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Mar 19, 2021

Please resolve the conflicts.

@lafriks
Copy link
Member

lafriks commented Mar 19, 2021

conflicts ;)

@6543 6543 mentioned this pull request Mar 19, 2021
Merged
zeripath
zeripath approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we need Xorm to be able to set aliases in this way with builder

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 19, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2021
@lafriks lafriks merged commit a3a6513 into go-gitea:master Mar 19, 2021
@lafriks lafriks deleted the fix-DB-insonsistenc-again branch March 19, 2021 19:01
6543 added a commit that referenced this pull request Mar 19, 2021
@6543
Delete Labels & IssueLabels on Repo Delete too (#15039) (#15051)
70e4134 
* Doctor: find IssueLabels without existing label

* Repo Delete: delete labels & issue_labels too
@6543 6543 added the backport/done All backports for this PR have been created label Mar 23, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

[BUG] Delete repo do not delete related issue_label entrys
5 participants
@6543 @lafriks @lunny @zeripath @GiteaBot