Performance improvement for last commit cache and show-ref #15455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t cache Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
performance/speed
zeripath
changed the title
zeripath
changed the title
zeripath
commented
Apr 13, 2021
| @@ -106,7 +124,6 @@ func (repo *Repository) getCommit(id SHA1) (*Commit, error) { | |||
| case "commit": | |||
| return CommitFromReader(repo, id, io.LimitReader(bufReader, size)) | |||
| default: | |||
| _ = stdoutReader.CloseWithError(fmt.Errorf("unknown typ: %s", typ)) | |||
There was a problem hiding this comment.
This was always unnecessary so it can be removed
GiteaBot
added
the
lgtm/need 2
6543
approved these changes
Apr 30, 2021
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
May 1, 2021
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #15455 +/- ##
==========================================
- Coverage 43.91% 43.90% -0.01%
==========================================
Files 678 678
Lines 81827 81838 +11
==========================================
+ Hits 35932 35933 +1
- Misses 40051 40055 +4
- Partials 5844 5850 +6
Continue to review full report at Codecov.
|
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 2, 2021
…15455) Backport go-gitea#15455 * Improve performance when there are multiple commits in the last commit cache * read refs directly if we can Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
pushed a commit
that referenced
this pull request
May 3, 2021
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on from #15447
This PR is an attempt to reduce the performance issues noted in #15413 and #15401