Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install curl on Dockerfile.rootless build for health check logic #15661

Closed
2 of 5 tasks
decentral1se opened this issue Apr 29, 2021 · 0 comments · Fixed by #15908
Closed
2 of 5 tasks

Install curl on Dockerfile.rootless build for health check logic #15661

decentral1se opened this issue Apr 29, 2021 · 0 comments · Fixed by #15908
Labels
topic/deployment topic/distribution This PR changes something about the packaging of Gitea type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@decentral1se
Copy link

  • Gitea version (or commit ref): 1.14.1-rootless
  • Git version: Latest stable on Debian 10
  • Operating system: GNU/Linux Debian 10
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • [] Yes (provide example URL)
    • No
  • Log gist:

Description

gitea/Dockerfile.rootless

Lines 33 to 38 in d7dbe4f

RUN apk --no-cache add \
bash \
ca-certificates \
gettext \
git \
gnupg

Can we also install curl here for healthcheck logic? Handy for docker swarm deployments when you want to run healtchecks locally on the container against ports. Otherwise we need to do a custom image and it is preferable to use upstream. Thanks for considering.

Screenshots
@noerw noerw added topic/deployment theme/docker type/proposal The new feature has not been accepted yet but needs to be discussed first. labels May 14, 2021
@justusbunsi justusbunsi mentioned this issue May 17, 2021
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@delvh delvh added topic/distribution This PR changes something about the packaging of Gitea and removed theme/docker labels Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/deployment topic/distribution This PR changes something about the packaging of Gitea type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add curl to rootless docker image justusbunsi/gitea
3 participants
@decentral1se @noerw @delvh