Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify migration descriptions #16777

Closed
delvh opened this issue Aug 23, 2021 · 1 comment · Fixed by #16781
Closed

Unify migration descriptions #16777

delvh opened this issue Aug 23, 2021 · 1 comment · Fixed by #16781

Comments

@delvh
Copy link
Member

delvh commented Aug 23, 2021

  • Gitea version (or commit ref): 1.16.0+dev-138-gdb1e3d02a

Description

Currently, there does not seem to exist a standard for the migration descriptions.
I, and most likely everyone else as well would prefer it, if these descriptions would be unified.
What do I mean by that?

  1. I would replace Migrating data … with its more precise version Migrate data … as currently no action is already being performed
  2. Some URLs are started with a capital letter, and some are not (example: Github.com, notabug.org). Either all URLs should start with their first letter capitalized, or none at all. In the first case: How do you handle urls with subdomains (especially code.onedev.io)? Do you capitalize all domain starting letters, or only the first?
  3. Unify the overall descriptions: Currently, the unique descriptions each differ slightly enough to be noticeable. I think it would be better to use a unified approach for everything such as Migrate data from <Provider.URL> or other <Provider> instances.
  4. Cut the or Mirroring from Migrating or Mirroring git data from Git services in migrate.git.description. All other migration descriptions also enable this and don't publicly announce it.

Screenshots

image
Current appearance (in 1.15, not current dev 1.16)
image
Expected result afterwards

@zeripath
Copy link
Contributor

I think it's probably best just to send a PR updating locale-en_US (with screenshots - although I know that's going to be annoying to do.)

@delvh delvh changed the title Unify translation strings for migrations Unify migration descriptions Aug 23, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants