Make ParsePatch more robust #17573
Merged
Make ParsePatch more robust #17573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle some possible but non-likely edge-cases of ParsePatch whereby it was possible that it could crash. - Tests are added and were the only 2 cases I could find.
zeripath
approved these changes
Nov 6, 2021
GiteaBot
added
the
lgtm/need 1
What miscount? |
|
I am responsible for the original miscount of characters that leads to this patch |
lunny
approved these changes
Nov 7, 2021
GiteaBot
added
lgtm/done
lafriks
approved these changes
Nov 7, 2021
Ah got it, no worries. It was only after plugging in some values to see how it handled "ambitious" values it panicked, otherwise I wouldn't have seen it as well. |
|
@Gusted thanks for this PR (and all the other ones recently), could you send this as a backport to 1.15.x? Also, are you on our discord? I have a question I'd like to ask. |
Gusted
pushed a commit
to Gusted/gitea
that referenced
this pull request
Nov 7, 2021
- Backport of go-gitea#17573
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was possible that it could crash.