Detect dark theme via css variable #17800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a good approach, the old way with the name check was a hack. I'm not sure about the removal of the |
GiteaBot
added
the
lgtm/need 2
|
Thought I guess if a dark theme is loaded as part of the auto-detection, it will have the variable as well, so I guess it's fine this way. |
Gusted
reviewed
Nov 24, 2021
Codecov Report
@@ Coverage Diff @@
## main #17800 +/- ##
==========================================
- Coverage 45.54% 45.54% -0.01%
==========================================
Files 807 808 +1
Lines 89859 90009 +150
==========================================
+ Hits 40930 40993 +63
- Misses 42381 42468 +87
Partials 6548 6548
Continue to review full report at Codecov.
|
Gusted
approved these changes
Nov 24, 2021
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Nov 24, 2021
silverwind
approved these changes
Nov 24, 2021
GiteaBot
added
lgtm/done
delvh
reviewed
Nov 24, 2021
wxiaoguang
approved these changes
Nov 25, 2021
Merged
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* detect dark theme via css variable * minor refactor, add documentation If your custom theme is considered a dark theme, set the global css variable `--is-dark-theme` to `true`. This allows gitea to adjust the Monaco code editor's theme accordingly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have just created a custom dark theme for my Gitea instance. It looks good, but the Monaco text editor did not pick up the dark theme like it does with the
arc-greentheme enabled.So I looked into the source and found out that the dark editor theme only gets enabled when the builtin
arc-greenorautotheme is chosen. Any additional themes are treated as light themes.That's why I updated the
isDarkTheme()function to look for the--is-dark-themecss variable. If that variable is set totrue, the editor dark mode gets enabled.And because CSS variables can be set within queries, too, responsive themes like
autoare possible without additional js logic.