Instead of using routerCtx just escape the url before routing #18086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A consequence of forcibly setting the RoutePath to the escaped url is that the auto routing to endpoints without terminal slashes fails (Causing go-gitea#18060.) This failure raises the possibility that forcibly setting the RoutePath causes other unexpected behaviours too. Therefore, instead we should simply pre-escape the URL in the process registering handler. Then the request URL will be properly escaped for all the following calls. Fix go-gitea#17938 Fix go-gitea#18060 Replace go-gitea#18062 Replace go-gitea#17997 Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## main #18086 +/- ##
==========================================
+ Coverage 44.87% 44.88% +0.01%
==========================================
Files 824 824
Lines 91511 91559 +48
==========================================
+ Hits 41068 41100 +32
- Misses 43855 43864 +9
- Partials 6588 6595 +7
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Dec 24, 2021
Signed-off-by: Andrew Thornton <art27@cantab.net>
wxiaoguang
approved these changes
Dec 24, 2021
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Dec 24, 2021
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Dec 24, 2021
zeripath
deleted the
alternate-fix-17938-18060-set-url-is-escapedpath
branch
zeripath
added
backport/v1.15
type/refactoring
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Dec 25, 2021
…ea#18086) Backport go-gitea#18086 A consequence of forcibly setting the RoutePath to the escaped url is that the auto routing to endpoints without terminal slashes fails (Causing go-gitea#18060.) This failure raises the possibility that forcibly setting the RoutePath causes other unexpected behaviors too. Therefore, instead we should simply pre-escape the URL in the process registering handler. Then the request URL will be properly escaped for all the following calls. Fix go-gitea#17938 Fix go-gitea#18060 Replace go-gitea#18062 Replace go-gitea#17997 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
backport/done
zeripath
added a commit
that referenced
this pull request
Dec 26, 2021
#18098) Backport #18086 A consequence of forcibly setting the RoutePath to the escaped url is that the auto routing to endpoints without terminal slashes fails (Causing #18060.) This failure raises the possibility that forcibly setting the RoutePath causes other unexpected behaviors too. Therefore, instead we should simply pre-escape the URL in the process registering handler. Then the request URL will be properly escaped for all the following calls. Fix #17938 Fix #18060 Replace #18062 Replace #17997 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Dec 28, 2021
* BUGFIXES * Revert "Fix delete u2f keys bug (go-gitea#18042)" (go-gitea#18107) * Migrating wiki don't require token, so we should move it out of the require form (go-gitea#17645) (go-gitea#18104) * Prevent NPE if gitea uploader fails to open url (go-gitea#18080) (go-gitea#18101) * Reset locale on login (go-gitea#17734) (go-gitea#18100) * Correctly handle failed migrations (go-gitea#17575) (go-gitea#18099) * Instead of using routerCtx just escape the url before routing (go-gitea#18086) (go-gitea#18098) * Quote references to the user table in consistency checks (go-gitea#18072) (go-gitea#18073) * Add NotFound handler (go-gitea#18062) (go-gitea#18067) * Ensure that git repository is closed before transfer (go-gitea#18049) (go-gitea#18057) * Use common sessioner for API and web routes (go-gitea#18114) * TRANSLATION * Fix code search result hint on zh-CN (go-gitea#18053) Signed-off-by: Andrew Thornton <art27@cantab.net>
Merged
lunny
added a commit
that referenced
this pull request
Dec 30, 2021
* BUGFIXES * Revert "Fix delete u2f keys bug (#18042)" (#18107) * Migrating wiki don't require token, so we should move it out of the require form (#17645) (#18104) * Prevent NPE if gitea uploader fails to open url (#18080) (#18101) * Reset locale on login (#17734) (#18100) * Correctly handle failed migrations (#17575) (#18099) * Instead of using routerCtx just escape the url before routing (#18086) (#18098) * Quote references to the user table in consistency checks (#18072) (#18073) * Add NotFound handler (#18062) (#18067) * Ensure that git repository is closed before transfer (#18049) (#18057) * Use common sessioner for API and web routes (#18114) * TRANSLATION * Fix code search result hint on zh-CN (#18053) Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…ea#18086) A consequence of forcibly setting the RoutePath to the escaped url is that the auto routing to endpoints without terminal slashes fails (Causing go-gitea#18060.) This failure raises the possibility that forcibly setting the RoutePath causes other unexpected behaviors too. Therefore, instead we should simply pre-escape the URL in the process registering handler. Then the request URL will be properly escaped for all the following calls. Fix go-gitea#17938 Fix go-gitea#18060 Replace go-gitea#18062 Replace go-gitea#17997 Signed-off-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A consequence of forcibly setting the RoutePath to the escaped url is that the
auto routing to endpoints without terminal slashes fails (Causing #18060.) This
failure raises the possibility that forcibly setting the RoutePath causes other
unexpected behaviours too.
Therefore, instead we should simply pre-escape the URL in the process registering
handler. Then the request URL will be properly escaped for all the following calls.
Fix #17938
Fix #18060
Replace #18062
Replace #17997
Signed-off-by: Andrew Thornton art27@cantab.net