-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ioutil
#18222
Remove ioutil
#18222
Conversation
- Don't use `ioutil` package anymore as it doesn't anything special anymore since Go 1.16: ``` // As of Go 1.16, the same functionality is now provided // by package io or package os, and those implementations // should be preferred in new code. ```
LGTM, could you also add a vet rule to block the import of ioutil? |
Codecov Report
@@ Coverage Diff @@
## main #18222 +/- ##
==========================================
- Coverage 45.64% 45.64% -0.01%
==========================================
Files 830 830
Lines 92020 92024 +4
==========================================
- Hits 42002 42001 -1
+ Misses 43283 43280 -3
- Partials 6735 6743 +8
Continue to review full report at Codecov.
|
|
* 'main' of https://github.com/go-gitea/gitea: [skip ci] Updated translations via Crowdin Fix source typos (go-gitea#18227) Fix various typos (go-gitea#18219) Remove `ioutil` (go-gitea#18222) [skip ci] Updated translations via Crowdin
- Don't use `ioutil` package anymore as it doesn't anything special anymore since Go 1.16: ``` // As of Go 1.16, the same functionality is now provided // by package io or package os, and those implementations // should be preferred in new code. ``` Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
ioutil
package anymore as it doesn't anything special anymore since Go 1.16: