Prevent security failure due to bad APP_ID #18678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebAuthn may cause a security exception if the provided APP_ID is not allowed for the current origin. Therefore we should reattempt authentication without the appid extension. Also we should allow [u2f] as-well as [U2F] sections. Signed-off-by: Andrew Thornton <art27@cantab.net>
lafriks
approved these changes
Feb 8, 2022
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Feb 9, 2022
GiteaBot
added
lgtm/done
|
This PR fixed the first authentication failure problem when setup 2FA. But it still has not resolve the migrated U2F keys invalid problem. Of course I think that could be another PR. |
Codecov Report
@@ Coverage Diff @@
## main #18678 +/- ##
==========================================
- Coverage 46.64% 46.63% -0.01%
==========================================
Files 846 846
Lines 121331 121367 +36
==========================================
+ Hits 56595 56605 +10
- Misses 57859 57888 +29
+ Partials 6877 6874 -3
Continue to review full report at Codecov.
|
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Feb 9, 2022
Backport go-gitea#18678 WebAuthn may cause a security exception if the provided APP_ID is not allowed for the current origin. Therefore we should reattempt authentication without the appid extension. Also we should allow [u2f] as-well as [U2F] sections. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 9, 2022
* giteaofficial/main: Prevent security failure due to bad APP_ID (go-gitea#18678) [skip ci] Updated translations via Crowdin Let `MinUnitAccessMode` return correct perm (go-gitea#18675) Simplify Boost/Pause logic (go-gitea#18673) update the comparison documents (go-gitea#18669) Restart zero worker if there is still work to do (go-gitea#18658)
silverwind
reviewed
Feb 10, 2022
| verifyAssertion(credential); | ||
| }).catch((err) => { | ||
| webAuthnError('general', err.message); | ||
| }); |
There was a problem hiding this comment.
This kind of screams to be refactored using await 😉
6543
pushed a commit
that referenced
this pull request
Feb 10, 2022
Backport #18678 WebAuthn may cause a security exception if the provided APP_ID is not allowed for the current origin. Therefore we should reattempt authentication without the appid extension. Also we should allow [u2f] as-well as [U2F] sections. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
WebAuthn may cause a security exception if the provided APP_ID is not allowed for the current origin. Therefore we should reattempt authentication without the appid extension. Also we should allow [u2f] as-well as [U2F] sections. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebAuthn may cause a security exception if the provided APP_ID is not allowed for the
current origin. Therefore we should reattempt authentication without the appid
extension.
Also we should allow [u2f] as-well as [U2F] sections.
Signed-off-by: Andrew Thornton art27@cantab.net