Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make git.OpenRepository accept Context #19260

Merged
merged 5 commits into from
Mar 29, 2022
Merged

Make git.OpenRepository accept Context #19260

merged 5 commits into from
Mar 29, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 29, 2022

as title

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 29, 2022
@6543 6543 added this to the 1.17.0 milestone Mar 29, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2022
6543
6543 commented Mar 29, 2022
View reviewed changes
services/pull/review.go Outdated Show resolved Hide resolved
modules/doctor/misc.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@889a8c2). Click here to learn what that means.
The diff coverage is 73.62%.

@@           Coverage Diff           @@
##             main   #19260   +/-   ##
=======================================
  Coverage        ?   46.40%           
=======================================
  Files           ?      870           
  Lines           ?   123401           
  Branches        ?        0           
=======================================
  Hits            ?    57268           
  Misses          ?    59178           
  Partials        ?     6955
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
models/organization/team_repo.go 76.19% <ø> (ø)
models/organization/team_user.go 74.57% <ø> (ø)
modules/doctor/misc.go 21.55% <0.00%> (ø)
modules/git/diff.go 76.22% <0.00%> (ø)
routers/web/repo/branch.go 57.32% <0.00%> (ø)
routers/web/repo/commit.go 26.16% <0.00%> (ø)
routers/web/repo/lfs.go 0.00% <0.00%> (ø)
services/pull/check.go 28.35% <0.00%> (ø)
services/pull/review.go 51.45% <0.00%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889a8c2...5b34bb1. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2022
@wxiaoguang wxiaoguang merged commit 3e88af8 into go-gitea:main Mar 29, 2022
@wxiaoguang wxiaoguang changed the title No git.OpenRepository() without context Make git.OpenRepository accept Context Mar 29, 2022
@6543 6543 deleted the no-OpenRepository-without-context branch March 29, 2022 20:22
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 30, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
f6c0470 
* giteaoffical/main: (31 commits)
  Add Package Registry (go-gitea#16510)
  Show messages for users if the ROOT_URL is wrong, show JavaScript errors (go-gitea#18971)
  [skip ci] Updated translations via Crowdin
  Make git.OpenRepository accept Context (go-gitea#19260)
  Use full output of git show-ref --tags to get tags for PushUpdateAddTag (go-gitea#19235)
  When conflicts have been previously detected ensure that they can be resolved (go-gitea#19247)
  More commit info from API (go-gitea#19252)
  Move some issue methods as functions (go-gitea#19255)
  Move project files into models/project sub package (go-gitea#17704)
  Granular webhook events in editHook (go-gitea#19251)
  Provide configuration to allow camo-media proxying (go-gitea#12802)
  Move init repository related functions to modules (go-gitea#19159)
  Move organization related structs into sub package (go-gitea#18518)
  Refactor repo clone button and repo clone links, fix JS error on empty repo page (go-gitea#19208)
  Show last cron messages on monitor page (go-gitea#19223)
  Allow API to create file on empty repo (go-gitea#19224)
  Use goproxy.io instead of goproxy.cn (go-gitea#19242)
  New cron task: delete old system notices (go-gitea#19219)
  Let web and API routes have different auth methods group (go-gitea#19168)
  Only send webhook events to active system webhooks and only deliver to active hooks (go-gitea#19234)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@6543 @codecov-commenter @zeripath @wxiaoguang @GiteaBot