Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models/webhook.go linting #198

Merged
merged 1 commit into from
Nov 22, 2016
Merged

models/webhook.go linting #198

merged 1 commit into from
Nov 22, 2016

Conversation

strk
Copy link
Member

@strk strk commented Nov 19, 2016

still incomplete

@codecov-io
Copy link

codecov-io commented Nov 19, 2016 •
edited
Loading

Current coverage is 3.03% (diff: 0.00%)

Merging #198 into master will not change coverage

@@            master      #198   diff @@
========================================
  Files           33        33          
  Lines         8106      8106          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           246       246          
  Misses        7840      7840          
  Partials        20        20

Powered by Codecov. Last update b2cce12...6cf115b

@andreynering andreynering added the pr/wip This PR is not ready for review label Nov 19, 2016
@strk strk changed the title [WIP] Some linting for webhook models/webhook.go linting Nov 20, 2016
@strk
Copy link
Member Author

strk commented Nov 20, 2016

This is ready for merge, please review.

@andreynering
Copy link
Contributor

This is not building:

# code.gitea.io/gitea/models
models/webhook.go:395: t.SimpleMarshalJSON undefined (type *HookTask has no field or method SimpleMarshalJSON, but does have simpleMarshalJSON)
models/webhook.go:398: t.SimpleMarshalJSON undefined (type *HookTask has no field or method SimpleMarshalJSON, but does have simpleMarshalJSON)

@lunny
Copy link
Member

lunny commented Nov 21, 2016

^

@lunny lunny added this to the 1.0.0 milestone Nov 21, 2016
@strk
Copy link
Member Author

strk commented Nov 21, 2016

Build should be fixed now, sorry for the noise

@lunny
Copy link
Member

lunny commented Nov 21, 2016

LGTM

@lunny lunny added type/docs This PR mainly updates/creates documentation type/enhancement An improvement of existing functionality and removed pr/wip This PR is not ready for review labels Nov 21, 2016
@thibaultmeyer
Copy link
Contributor

LGTM

@lunny lunny merged commit c25063d into go-gitea:master Nov 22, 2016
@strk strk deleted the webhook-lint branch November 22, 2016 08:27
@lunny
Copy link
Member

lunny commented Nov 28, 2016

resolved #70

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting and removed type/docs This PR mainly updates/creates documentation type/enhancement An improvement of existing functionality labels Nov 28, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@strk @codecov-io @andreynering @lunny @thibaultmeyer @tboerger