Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete duplicated update btn on pull request view page #19993

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Delete duplicated update btn on pull request view page #19993

merged 1 commit into from
Jun 17, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 17, 2022

Fix #19987

@lunny lunny added the type/bug label Jun 17, 2022
@lunny lunny added this to the 1.17.0 milestone Jun 17, 2022
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 17, 2022
wxiaoguang
wxiaoguang approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff of these two code block shows that the fix is right.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 17, 2022
@zeripath zeripath changed the title delete duplicated update btn on pull request view page Delete duplicated update btn on pull request view page Jun 17, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2022
@zeripath zeripath merged commit 1e05adf into go-gitea:main Jun 17, 2022
@lunny lunny deleted the lunny/fix_duplicated_update_btn branch June 17, 2022 06:41
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@lunny
Delete duplicated update btn on pull request view page (go-gitea#19993)
4b6b1b8 
Fix go-gitea#19987
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@lunny @AbdulrhmnGhanem
Delete duplicated update btn on pull request view page (go-gitea#19993)
193a2c1 
Fix go-gitea#19987
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Duplicate "update by merge" button
5 participants
@lunny @zeripath @wxiaoguang @techknowlogick @GiteaBot