Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide internal package versions #20492

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Hide internal package versions #20492

merged 2 commits into from
Jul 27, 2022

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jul 26, 2022

fixes #20491

At the moment only the container packages use internal versions so I forgot to restrict the api to display these versions. This PR simply restricts all searches.

#18064 made the IsInternal optional which resulted in the wrong API result.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 26, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 26, 2022
@lunny lunny merged commit a3d55ac into go-gitea:main Jul 27, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 27, 2022
* giteaofficial/main:
  Hide internal package versions (go-gitea#20492)
  Fix org members bug (go-gitea#20489)
  Add labels to two buttons that were missing them (go-gitea#20419)
  fix enabling repo packages when projects are off (go-gitea#20486)
  Display project in issue list (go-gitea#20434)
  Make code review ceckboxes clickable (go-gitea#20481)
  Slightly simplify LastCommitCache (go-gitea#20444)
@KN4CK3R KN4CK3R deleted the fix-20491 branch July 27, 2022 07:18
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Jul 27, 2022
* Hide internal versions from most searches.

* Added test.
@KN4CK3R KN4CK3R added issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself and removed type/bug labels Jul 27, 2022
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
* Hide internal versions from most searches.

* Added test.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/api/v1/packages/<user> returns internal/temporary _upload tag
7 participants