Pad GPG Key ID with preceding zeroes #20878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go crypto library does not pad keyIDs to 16 characters with preceding zeroes. This is a somewhat confusing thing for most users who expect these to have preceding zeroes. This PR prefixes any sub 16 length KeyID with preceding zeroes and removes preceding zeroes from KeyIDs inputted on the API. Fix go-gitea#20876 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
fix-20876-pad-gpg-key-ids
branch
from
7aab45a
to
bdf3c80
Compare
techknowlogick
approved these changes
Aug 20, 2022
GiteaBot
added
the
lgtm/need 1
delvh
approved these changes
Aug 20, 2022
| @@ -177,6 +178,12 @@ func VerifyUserGPGKey(ctx *context.APIContext) { | |||
| token := asymkey_model.VerificationToken(ctx.Doer, 1) | |||
| lastToken := asymkey_model.VerificationToken(ctx.Doer, 0) | |||
|
|
|||
| form.KeyID = strings.TrimLeft(form.KeyID, "0") | |||
There was a problem hiding this comment.
Can keys start with zeros, or is a leading zero always seen as padding?
Because if it is the former, this will probably produce a lot of problems in the future…
There was a problem hiding this comment.
Take a look at pubkey.KeyIDString()
The trimming is to fix potential issues relating to that
GiteaBot
added
lgtm/done
|
I have another question. Why is |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Aug 21, 2022
Backport go-gitea#20878 The go crypto library does not pad keyIDs to 16 characters with preceding zeroes. This is a somewhat confusing thing for most users who expect these to have preceding zeroes. This PR prefixes any sub 16 length KeyID with preceding zeroes and removes preceding zeroes from KeyIDs inputted on the API. Fix go-gitea#20876 Signed-off-by: Andrew Thornton <art27@cantab.net>
I'm afraid I don't understand what you're talking about. Open a new issue with an example. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 22, 2022
* giteaofficial/main: update current stable version [skip ci] Updated translations via Crowdin Fix mirror address setting not working (go-gitea#20850) Support Proxy protocol (go-gitea#12527) Fix SQL Query for `SearchTeam` (go-gitea#20844) Double check CloneURL is acceptable (go-gitea#20869) Fix graceful doc (go-gitea#20883) Pad GPG Key ID with preceding zeroes (go-gitea#20878) [skip ci] Updated translations via Crowdin call builtinUnused() if internal SSH is disabled (go-gitea#20877) Don't open new page for ext wiki on same repository (go-gitea#20725) [skip ci] Updated translations via Crowdin Fix the mode of custom dir to 0700 in docker-rootless (go-gitea#20861) Fix UI mis-align for PR commit history (go-gitea#20845)
zeripath
added a commit
that referenced
this pull request
Aug 22, 2022
Backport #20878 The go crypto library does not pad keyIDs to 16 characters with preceding zeroes. This is a somewhat confusing thing for most users who expect these to have preceding zeroes. This PR prefixes any sub 16 length KeyID with preceding zeroes and removes preceding zeroes from KeyIDs inputted on the API. Fix #20876 Signed-off-by: Andrew Thornton <art27@cantab.net>
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go crypto library does not pad keyIDs to 16 characters with preceding zeroes. This
is a somewhat confusing thing for most users who expect these to have preceding zeroes.
This PR prefixes any sub 16 length KeyID with preceding zeroes and removes preceding
zeroes from KeyIDs inputted on the API.
Fix #20876
Signed-off-by: Andrew Thornton art27@cantab.net