Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less verbose integration tests #2123

Merged
merged 3 commits into from
Jul 7, 2017
Merged

Less verbose integration tests #2123

merged 3 commits into from
Jul 7, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jul 7, 2017 •
edited
Loading

Changes to make integration tests less verbose

  • Add expected status code argument to MakeRequest(..), which saves a lot of assert.EqualValues(t, http.StatusXYZ, resp.HeaderCode) lines
  • Helper function to get CSRF token (GetCSRF(..))
  • Helper function for getting redirect URL (RedirectURL(..))

@ethantkoenig ethantkoenig changed the title Refactor/integration Less verbose integration tests Jul 7, 2017
@lafriks
Copy link
Member

lafriks commented Jul 7, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 7, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Jul 7, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 7, 2017
@bkcsoft bkcsoft merged commit f1adaef into go-gitea:master Jul 7, 2017
@lunny lunny added this to the 1.2.0 milestone Jul 8, 2017
@ethantkoenig ethantkoenig deleted the refactor/integration branch July 10, 2017 22:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ethantkoenig @lafriks @bkcsoft @lunny @tboerger