Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[template] Move all js on head part #2179

Closed
camlafit opened this issue Jul 18, 2017 · 1 comment
Closed

[template] Move all js on head part #2179

camlafit opened this issue Jul 18, 2017 · 1 comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Comments

@camlafit
Copy link
Contributor

Hi

Template system have move some js call on footer page (I presume to performance issue). But I'm not sure is nice to use it in default template :

  • Defer attribute is now correctly supported (http://caniuse.com/#feat=script-defer)
  • is harder to configure a proxy cache/concatenation
  • override template is not intuitive (two template files to change/check head and footer)
  • jquery dependencies
@lafriks lafriks added this to the 1.x.x milestone Jul 18, 2017
@lafriks lafriks added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Jul 18, 2017
@techknowlogick
Copy link
Member

We've now mostly moved to using webpack, and so we pack all JS into one file (kinda, webpack has a webloader that'll load the relevant bits needed).

@lafriks lafriks removed this from the 1.x.x milestone Dec 9, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

No branches or pull requests

3 participants