Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HEAD requests in Maven registry #21834

Merged
merged 7 commits into from
Nov 24, 2022
Merged

Add support for HEAD requests in Maven registry #21834

merged 7 commits into from
Nov 24, 2022

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Nov 16, 2022

Related #18543

@KN4CK3R KN4CK3R added this to the 1.19.0 milestone Nov 16, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 16, 2022
wxiaoguang
wxiaoguang approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. A small question as comment above (not blocker)

modules/context/context.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 17, 2022
@KN4CK3R KN4CK3R added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Nov 17, 2022
@delvh
Copy link
Member

delvh commented Nov 17, 2022 •
edited
Loading

I think a lot of statements can be rewritten now that #21833 is merged.

@zeripath
Copy link
Contributor

Linter is moaning ...

@KN4CK3R KN4CK3R removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Nov 23, 2022
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 24, 2022
@lafriks
Copy link
Member

lafriks commented Nov 24, 2022

🚀

@lafriks lafriks merged commit fc7a2d5 into go-gitea:main Nov 24, 2022
@lafriks lafriks removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 24, 2022
@KN4CK3R KN4CK3R deleted the fix-maven-header branch November 24, 2022 14:33
@delvh

This comment was marked as outdated.

Sign in to view
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Nov 24, 2022

Which statements would you rewrite?

@delvh
Copy link
Member

delvh commented Nov 24, 2022

My bad.
I didn't expect that you would rewrite the statements inside a merge commit,
and so I thought it would still need to be implemented.

KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Nov 24, 2022
@KN4CK3R @lunny
Add support for HEAD requests in Maven registry (go-gitea#21834)
1f7909c 
Related go-gitea#18543

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@KN4CK3R KN4CK3R mentioned this pull request Nov 24, 2022
Merged
@KN4CK3R
Copy link
Member Author

KN4CK3R commented Nov 24, 2022

Backporting this to 1.17 is problematic because there were lots of (type) changes. But as 1.18 should be released in the near future, that should not be a problem.

@lunny lunny added the backport/done All backports for this PR have been created label Nov 25, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 25, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1a3fa0d 
* giteaofficial/main:
  Workaround for container registry push/pull errors (go-gitea#21862)
  Fix scroll over mermaid frame (go-gitea#21925)
  Add support for HEAD requests in Maven registry (go-gitea#21834)
  Fix button in branch list, avoid unexpected page jump before restore branch actually done (go-gitea#21562)
  Fix typo in sidebar (go-gitea#21922)
  Fix table misalignments and tweak webhook and githook lists (go-gitea#21917)
lafriks pushed a commit that referenced this pull request Nov 25, 2022
@KN4CK3R @lunny
Add support for HEAD requests in Maven registry (#21834) (#21929)
ff4e292 
Backport of #21834

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.18 This PR should be backported to Gitea 1.18 topic/packages type/bug
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
8 participants
@KN4CK3R @delvh @zeripath @lafriks @silverwind @wxiaoguang @lunny @GiteaBot