-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gitea/test_env
image instead of golang
#23455
Conversation
The step order is still messed up and it sometimes does not execute early enough it seems. |
May need to set |
This should be better, but drone does not show order graph yet, I guess we need to wait until execution begins or ends. |
Nope, it does not fix it: https://drone.gitea.io/go-gitea/gitea/69485/2/6 The command writes into I think we need a |
Local config does not work as git will not even read it. I'm out of ideas besides |
Yes, the |
#23464 may solve some issues, as in the container I set the safe directory of git to * so it'll be that for each time the container is used. |
|
I wouldn't mind that, as with the recent improvements to test_env builds, it's much easier to update them as needed. |
I removed the gitea/test_env:linux-1.20-amd64 instead of golang:1.20 The release pipelines also had this git config command, but I think it never had any effect there because it modifies files outside the working directory, which are discarded when drone enters the next step in a pipeline. |
This avoids errors related to git's safe.directory in the golang image.
fdf9ad7
to
d83fb70
Compare
gitea/test_env
image instead of golang
Squashed and renamed PR. @techknowlogick One more question regarding |
@silverwind thank you so |
* giteaofficial/main: (33 commits) Bump webpack from 5.75.0 to 5.76.0 (go-gitea#23484) Replace Less with CSS (go-gitea#23481) Fix 'View File' button in code search (go-gitea#23478) Use `gitea/test_env` image instead of `golang` (go-gitea#23455) Skip DB tests duplicate runs on push to branches (go-gitea#23476) Update app.example.ini (go-gitea#23480) [skip ci] Updated translations via Crowdin Fix due date being wrong on issue list (go-gitea#23475) test_env: hardcode major go version in use (go-gitea#23464) Push option bonus for PTC docs (go-gitea#23473) Lint Markdown pass Push to create docs (go-gitea#23458) Convert GitHub event on actions and fix some pull_request events. (go-gitea#23037) Remove wrongly added column on migration test fixtures (go-gitea#23456) Refactor branch/tag selector to Vue SFC (go-gitea#23421) add admin API email endpoints (go-gitea#22792) add user rename endpoint to admin api (go-gitea#22789) Add workflow error notification in ui (go-gitea#23404) Make branches list page operations remember current page (go-gitea#23420) fix markdown lint issue (go-gitea#23457) ...
The
safe.directory
setting was not executed for pull requests, which made subsequentdeps-backend
target fail atgo mod download
. To fix it, split thep and perform the git config unconditionally.Example: https://drone.gitea.io/go-gitea/gitea/69477/4/3