Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Make Repository Private" option should be moved into the "Danger Zone" settings area #23826

Closed
alystair opened this issue Mar 30, 2023 · 4 comments · Fixed by #31126
Closed

"Make Repository Private" option should be moved into the "Danger Zone" settings area #23826

alystair opened this issue Mar 30, 2023 · 4 comments · Fixed by #31126
Assignees
@fabiobarkoski
Labels
good first issue Likely to be an easy fix topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.23.0

Comments

@alystair
Copy link

alystair commented Mar 30, 2023 •
edited
Loading

Feature Description

Changing the visibility of a repo is a non-trivial decision after creation as it can affect many users and has potential knock-on effects.

Screenshots

Gitea
Current Gitea implementation

GitHub
GitHub
@alystair alystair added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Mar 30, 2023
This was referenced Oct 11, 2023
Closed
Closed
@6543 6543 added topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/enhancement An improvement of existing functionality good first issue Likely to be an easy fix and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Oct 15, 2023
@fabiobarkoski
Copy link
Contributor

Can I work on this issue, or it was solved?

@lunny
Copy link
Member

lunny commented May 23, 2024 •
edited
Loading

Can I work on this issue, or it was solved?

Sure. And this hasn't been resolved.

@fabiobarkoski
Copy link
Contributor

Reading the code, it seems that a user can change repo visibility. If so, isn't it better that only admins can change the visibility?

@lunny
Copy link
Member

lunny commented May 25, 2024

Reading the code, it seems that a user can change repo visibility. If so, isn't it better that only admins can change the visibility?

Yes, I think the permissions have been checked. We just need frontend changes.

@fabiobarkoski fabiobarkoski mentioned this issue May 27, 2024
Merged
lafriks pushed a commit that referenced this issue Aug 11, 2024
@fabiobarkoski @kemzeb
Move repository visibility to danger zone in the settings area (#31126)
e45a4c9 
Moved repository visibility to the danger zone in the settings area. To
change the visibility, it is necessary to go to the danger zone, click
on the private/public button, and accept the change in the modal.

Resolves:  #23826

---
## Screenshots

<details>
<summary>Before</summary>
Private repo:

![Private
repo](https://github.com/go-gitea/gitea/assets/65479069/4313492a-4854-48bc-9f47-974e3539d791)

Public repo:

![Public
repo](https://github.com/go-gitea/gitea/assets/65479069/1c45f6e4-ee93-4799-9331-e9d4a7e0f16a)

</details>
<details>
<summary>After</summary>
Make private:

![Screenshot from 2024-05-28
21-35-38](https://github.com/go-gitea/gitea/assets/65479069/4887e28a-0514-4990-aa69-bf3ddc7e6c7d)

Make private modal

![Screenshot from 2024-06-13
23-55-55](https://github.com/go-gitea/gitea/assets/65479069/9f5a7604-069b-41a2-973b-ee2d58e85953)

![Screenshot from 2024-06-13
23-53-09](https://github.com/go-gitea/gitea/assets/65479069/06c22726-eab2-4bce-8df7-62849dcce974)

Make public:

![Screenshot from 2024-05-28
21-34-27](https://github.com/go-gitea/gitea/assets/65479069/6d388f99-0356-48a0-9d85-320cdba55179)

Make public modal

![Screenshot from 2024-06-13
23-53-37](https://github.com/go-gitea/gitea/assets/65479069/8944972e-f2d4-4aea-ba96-b892febb5ced)

</details>

---------

Co-authored-by: Kemal Zebari <60799661+kemzeb@users.noreply.github.com>
@lunny lunny added this to the 1.23.0 milestone Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabiobarkoski fabiobarkoski

Labels
good first issue Likely to be an easy fix topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.23.0
4 participants
@lunny @alystair @6543 @fabiobarkoski