-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move repository visibility to danger zone in the settings area #31126
Move repository visibility to danger zone in the settings area #31126
Conversation
The warning should have more details. Make a repository private may remove the relation between it and forks, watchers and stars. |
I would like the backend code should also be changed. There should be two new functions at service layer named |
Sure, but isn't it better just one function named |
They are opposite actions, not the same. I don't think they will share much code. |
@@ -2446,6 +2446,13 @@ settings.thread_id = Thread ID | |||
settings.matrix.homeserver_url = Homeserver URL | |||
settings.matrix.room_id = Room ID | |||
settings.matrix.message_type = Message Type | |||
settings.visibility.private.button = Make Private | |||
settings.visibility.private.text = Changing the visibility to private will not only make the repo visible to only allowed members but may remove the relation between it and forks, watchers, and stars. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, It might be more understandable and user friendly to display this warning as bullet marks like:
Changing the visibility to private will:
- Make the repository only visible to yourself and members who have access
- Remove any affiliation between this repository and any forks, watchers, and stars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, but I think will need to change the archive text to bullet marks too, to keep the consistency.
Yeah, you're right, I've expressed myself badly.
Both using the |
Moved to danger zone because change the visibility is a non-trivial decision, so that way the repo admin need to go to the danger zone to change.
Co-authored-by: Kemal Zebari <60799661+kemzeb@users.noreply.github.com>
b591e74
to
dbca558
Compare
* giteaofficial/main: Show lock owner instead of repo owner on LFS setting page (go-gitea#31788) Move repository visibility to danger zone in the settings area (go-gitea#31126) [skip ci] Updated translations via Crowdin Add types to various low-level functions (go-gitea#31781) Add warning message in merge instructions when `AutodetectManualMerge` was not enabled (go-gitea#31805) Show latest run when visit /run/latest (go-gitea#31808) Fix typo for `LOG_COMPRESSION` in ini (go-gitea#31809) Add label `docs-update-needed` for PRs that modify `app.example.ini` (go-gitea#31810) Fix `IsObjectExist` with gogit (go-gitea#31790) Support compression for Actions logs (go-gitea#31761) Add issue comment when moving issues from one column to another of the project (go-gitea#29311) [skip ci] Updated translations via Crowdin Fix RPM resource leak (go-gitea#31794)
Moved repository visibility to the danger zone in the settings area. To change the visibility, it is necessary to go to the danger zone, click on the private/public button, and accept the change in the modal.
Resolves: #23826
Screenshots
Before
Private repo:Public repo:
After
Make private:Make private modal
Make public:
Make public modal