Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark public/img/svg/*.svg as generated files #24193

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Mark public/img/svg/*.svg as generated files #24193

merged 3 commits into from
Apr 18, 2023

Conversation

yardenshoham
Copy link
Member

These files are generated using make svg

@yardenshoham
Mark public/img/svg/*.svg as generated files
f28d8ca 
These files are generated using `make svg`
@yardenshoham yardenshoham added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 18, 2023
@yardenshoham yardenshoham added this to the 1.20.0 milestone Apr 18, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 18, 2023
delvh
delvh approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I wonder how you could have noticed this problem…

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2023
@delvh delvh added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 18, 2023
@yardenshoham yardenshoham added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Apr 18, 2023
@silverwind silverwind enabled auto-merge (squash) April 18, 2023 16:59
@silverwind silverwind merged commit 75b9845 into go-gitea:main Apr 18, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2023
@yardenshoham yardenshoham deleted the svg-gen branch April 18, 2023 17:53
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yardenshoham @silverwind @delvh @GiteaBot