Fix the incorrect route path in the user edit page.

[CaiCandong]

Regression of #26713

After #26713 , the base path of user edit has been changed to /admin/users/{userid}/edit

Before

demo.mp4

[wxiaoguang]

No, do not do this ctx.Data["Link"] = "/admin/users/" + ctx.Params(":userid") , it is wrong.

dismiss

[wxiaoguang]

It is still not right.

You only have BaseUrl in EditUser, but not in EditUserPost ....

ps: I really dislike playing such tricks

[denyskon]

Honestly, I don't really understand what this PR is trying to do....

[CaiCandong]

The Link used to splice the route address started out as /admin/users/{userId}, but now it becomes /admin/users/{userId}/edit. This results in a 404 for requests for user deletion, avatar upload, etc. to the same route.

[puni9869]

It is still not right.

You only have BaseUrl in EditUser, but not in EditUserPost ....

ps: I really dislike playing such tricks

I agree with @wxiaoguang BaseUrl should not be override.

[CaiCandong]

I mean ctx["PathVaribleName"] = fmt.Printf("<pathurl>/%s", variableName) in the go code.

In the template {{.PathVaribleName}}/slug

<form class="ui form" action="{{.BaseUrl}}/edit" method="post">
ctx.Data["BaseUrl"] = "/admin/users/" + ctx.Params(":userid")

Maybe I've done what you said?

[puni9869]

Apologies for the syntax typo. ctx.Data["PathV...
ctx.Data["PathVaribleName"] = fmt.Printf("<pathurl>/%s", variableName)

[wxiaoguang]

It is still not right.

You only have BaseUrl in EditUser, but not in EditUserPost ....

Still not fixed.

Actually, the relative URL could also help. If the browser's current URL is /foo/bar, then ./xxx means /foo/xxx.

[CaiCandong]

Actually, the relative URL could also help. If the browser's current URL is /foo/bar, then ./xxx means /foo/xxx.

Thank you so much for your patient advice, I'll try this method.

[wxiaoguang]

Keep in mind, Gitea has a very unfriendly backend approach: if you put a variable in Xxx handler (UserEdit) , then you might also need to put it in XxxPost handler (UserEditPost). Otherwise, if an user-side error occurs when the end user submits the form, the re-rendered page will go wrong.

Or, just like this PR does, get rid of such variables.

[CaiCandong]

Keep in mind, Gitea has a very unfriendly backend approach: if you put a variable in Xxx handler (UserEdit) , then you might also need to put it in XxxPost handler (UserEditPost). Otherwise, if an user-side error occurs when the end user submits the form, the re-rendered page will go wrong.

Thank you so much for your patience and guidance

[puni9869]

are we good with PR.
if Y 🚀