Redefine the meaning of column is_active to make Actions Registration Token generation easier #27143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
the
modifies/api
This was referenced Sep 20, 2023
lunny
changed the title
lunny
changed the title
GiteaBot
added
lgtm/need 1
Zettat123
approved these changes
Sep 27, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 27, 2023
… Token generation easier (go-gitea#27143) Partially Fix go-gitea#25041 This PR redefined the meaning of column `is_active` in table `action_runner_token`. Before this PR, `is_active` means whether it has been used by any runner. If it's true, other runner cannot use it to register again. In this PR, `is_active` means whether it's validated to be used to register runner. And if it's true, then it can be used to register runners until it become false. When creating a new `is_active` register token, any previous tokens will be set `is_active` to false.
GiteaBot
removed
the
reviewed/wait-merge
lunny
added a commit
that referenced
this pull request
Sep 28, 2023
… Token generation easier (#27143) (#27304) Backport #27143 by @lunny Partially Fix #25041 This PR redefined the meaning of column `is_active` in table `action_runner_token`. Before this PR, `is_active` means whether it has been used by any runner. If it's true, other runner cannot use it to register again. In this PR, `is_active` means whether it's validated to be used to register runner. And if it's true, then it can be used to register runners until it become false. When creating a new `is_active` register token, any previous tokens will be set `is_active` to false. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 28, 2023
* giteaoffical/main: (22 commits) Fix review UI (go-gitea#27322) Improve issue history dialog and make poster can delete their own history (go-gitea#27323) Improve branch list UI (go-gitea#27319) doctor: delete action entries without existing user (go-gitea#27292) fix orphan check for deleted branch (go-gitea#27310) make writing main test easier (go-gitea#27270) [skip ci] Updated translations via Crowdin Fix protected branch icon location (go-gitea#26576) move the `gitea admin` subcommands into separate files (go-gitea#27307) Fix chinese translation (go-gitea#27296) bump bleve (go-gitea#27300) Redefine the meaning of column is_active to make Actions Registration Token generation easier (go-gitea#27143) Use vitest globals (go-gitea#27102) Fix divider in subscription page (go-gitea#27298) Fix yaml test (go-gitea#27297) Enable production source maps for index.js, fix CSS sourcemaps (go-gitea#27291) Fix some animation bugs (go-gitea#27287) Add missed return to actions view fetch (go-gitea#27289) Fix more yaml lint errors (go-gitea#27284) Fix incorrect change from go-gitea#27231 (go-gitea#27275) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fix #25041
This PR redefined the meaning of column
is_activein tableaction_runner_token.Before this PR,
is_activemeans whether it has been used by any runner. If it's true, other runner cannot use it to register again.In this PR,
is_activemeans whether it's validated to be used to register runner. And if it's true, then it can be used to register runners until it become false. When creating a newis_activeregister token, any previous tokens will be setis_activeto false.