Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for PR functionality when issues are disabled #2715

Closed
lafriks opened this issue Oct 16, 2017 · 7 comments
Closed

Integration tests for PR functionality when issues are disabled #2715

lafriks opened this issue Oct 16, 2017 · 7 comments

Comments

@lafriks
Copy link
Member

lafriks commented Oct 16, 2017

Need integration tests for #2710

@lafriks lafriks added this to the 1.x.x milestone Oct 16, 2017
@jonasfranz
Copy link
Member

I've created some tests. But I'am not sure if they work properly and if they test everything needed.

My branch: https://github.com/go-gitea/gitea/compare/master...JonasFranzDEV:integration-test-pr?expand=1

Is there a good way to test integration tests locally? drone cli does not work for some reason.

@Morlinest
Copy link
Member

@JonasFranzDEV You can run it same as make test but you need database up and running. I use 2 docker containers (gitea and db) on same custom network.

@jonasfranz
Copy link
Member

@Morlinest could you send me your docker commands or docker-compose file?

@Morlinest
Copy link
Member

@JonasFranzDEV I am using my own image (#2377), but you can try something like this (I can't test it because I can't mount local volumes now):

docker network create gitea-test
docker run -d --rm --net gitea-test -e POSTGRES_DB=test --name pgsql postgres:9.5
docker run -i --rm --net gitea-test -v <MY-PROJECT-PATH>:/srv/app/src/code.gitea.io/gitea -w /srv/app/src/code.gitea.io/gitea --net gitea -e TAGS="bindata" webh
ippie/golang:edge make clean generate build test-pgsql

Change <MY-PROJECT-PATH> for your path to project.

@lafriks
Copy link
Member Author

lafriks commented Oct 17, 2017

This issue is about that that when issues in repository is disabled in PR it was not possible (tests must test that is possible) to:

  • Add/remove labels
  • Set/remove milestone
  • Set/remove assignee
  • Add/change/delete comment
  • Start/stop/add timetracking
  • Close PR
  • Multi-PR actions from PR list

@stale
Copy link

stale bot commented Feb 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 11, 2019
@stale
Copy link

stale bot commented Feb 26, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Feb 26, 2019
@lafriks lafriks removed this from the 1.x.x milestone Feb 26, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants