Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go-deps #27489

Merged
merged 29 commits into from
Oct 7, 2023
Merged

bump go-deps #27489

merged 29 commits into from
Oct 7, 2023

Conversation

techknowlogick
Copy link
Member

No description provided.

@techknowlogick techknowlogick added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2023
@delvh
Copy link
Member

delvh commented Oct 6, 2023

Backport 1.21?

@techknowlogick techknowlogick added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 6, 2023
@techknowlogick
Copy link
Member Author

Backport 1.21?

Thanks for the suggestion. That's a good idea. I've added the label :)

go.mod Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 7, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 7, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) October 7, 2023 05:37
@techknowlogick techknowlogick merged commit e3229c8 into go-gitea:main Oct 7, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 7, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 7, 2023
@GiteaBot GiteaBot mentioned this pull request Oct 7, 2023
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 7, 2023
@silverwind
Copy link
Member

silverwind commented Oct 7, 2023

As already mentioned in the backport, it seems the gocron bump introduced this build failure:

https://github.com/go-gitea/gitea/actions/runs/6441499888/job/17491365648?pr=27501

--- FAIL: TestAddTaskToScheduler (0.00s)
    tasks_test.go:38: 
        	Error Trace:	/home/runner/work/gitea/gitea/services/cron/tasks_test.go:38
        	Error:      	Not equal: 
        	            	expected: "task 2"
        	            	actual  : "task 1"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-task 2
        	            	+task 1
        	Test:       	TestAddTaskToScheduler
    tasks_test.go:39: 
        	Error Trace:	/home/runner/work/gitea/gitea/services/cron/tasks_test.go:39
        	Error:      	Not equal: 
        	            	expected: "30 5 4 * * *"
        	            	actual  : "5 4 * * *"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-30 5 4 * * *
        	            	+5 4 * * *
        	Test:       	TestAddTaskToScheduler

@techknowlogick techknowlogick deleted the go-bump branch October 7, 2023 23:56
silverwind added a commit that referenced this pull request Oct 8, 2023
Backport #27489 by @techknowlogick

---------

Co-authored-by: techknowlogick <techknowlogick@gitea.com>
Co-authored-by: silverwind <me@silverwind.io>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 8, 2023
* giteaoffical/main: (79 commits)
  Pre-register OAuth application for tea (go-gitea#27509)
  Fix mermaid flowchart margin issue (go-gitea#27503)
  add a shortcut to user's profile page to admin user details (go-gitea#27299)
  Fix actionlint (go-gitea#27513)
  [skip ci] Updated translations via Crowdin
  Update JS and PY dependencies (go-gitea#27501)
  Improve feed icons and feed merge text color (go-gitea#27498)
  Downgrade `go-co-op/gocron` to v1.31.1 (go-gitea#27511)
  Enable markdownlint `no-duplicate-header` (go-gitea#27500)
  bump go-deps (go-gitea#27489)
  Apply to became a maintainer (go-gitea#27491)
  change runner for binary
  [skip ci] Updated translations via Crowdin
  Remove .exe suffix when cross-compiling on Windows (go-gitea#27448)
  move re-useable workflow
  add checkout to disk-clean
  use hosted runners for nightly actions (go-gitea#27485)
  Avoid run change title process when the title is same (go-gitea#27467)
  Fix panic in storageHandler (go-gitea#27446)
  Rename the default themes to gitea-light, gitea-dark, gitea-auto (go-gitea#27419)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants