Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert en-US locale #2821

Merged
merged 2 commits into from
Nov 1, 2017
Merged

Revert en-US locale #2821

merged 2 commits into from
Nov 1, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Nov 1, 2017

Revert wrongly updated options/locale/locale_en-US.ini file back to previous version

@lafriks lafriks added this to the 1.3.0 milestone Nov 1, 2017
@lafriks lafriks added issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Nov 1, 2017
@daviian
Copy link
Member

daviian commented Nov 1, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 1, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Nov 1, 2017

Won't this just get changed again by the CI job?

@lunny
Copy link
Member

lunny commented Nov 1, 2017

@lafriks Maybe we have to fix drone at first if it will update en_US ini file again?

@codecov-io
Copy link

codecov-io commented Nov 1, 2017 •
edited
Loading

Codecov Report

Merging #2821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2821   +/-   ##
=======================================
  Coverage   26.84%   26.84%           
=======================================
  Files          89       89           
  Lines       17608    17608           
=======================================
  Hits         4727     4727           
  Misses      12195    12195           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3217102...1daddf3. Read the comment docs.

@appleboy
Copy link
Member

appleboy commented Nov 1, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2017
@lafriks
Copy link
Member Author

lafriks commented Nov 1, 2017

Make LG-TM work

@lunny lunny merged commit 266ebf8 into go-gitea:master Nov 1, 2017
@lafriks lafriks deleted the revert/en_us_translations branch November 1, 2017 17:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
7 participants
@lafriks @daviian @bkcsoft @lunny @codecov-io @appleboy @tboerger