Remove lightningcss #29070
Merged
Remove lightningcss #29070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove lightningcss and minify with esbuild again. The size of CSS will slightly increase, but I think it's worth it to allow building gitea in more cases like the one in the linked issue. We can reconsider once lightningcss becomes more stable. Fixes: go-gitea#29058
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
delvh
approved these changes
Feb 7, 2024
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Feb 7, 2024
GiteaBot
added
lgtm/done
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
Remove lightningcss and minify with esbuild again. The size of output CSS will increase by around 1.4%, but I think it's worth it to allow building gitea in more cases like the one in the linked issue. We can reconsider once lightningcss becomes more stable. Fixes: go-gitea#29058
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
Remove lightningcss and minify with esbuild again. The size of output CSS will increase by around 1.4%, but I think it's worth it to allow building gitea in more cases like the one in the linked issue. We can reconsider once lightningcss becomes more stable. Fixes: go-gitea#29058 (cherry picked from commit 5849d4f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove lightningcss and minify with esbuild again. The size of output CSS will increase by around 1.4%, but I think it's worth it to allow building gitea in more cases like the one in the linked issue. We can reconsider once lightningcss becomes more stable.
Fixes: #29058
Upstream issue: parcel-bundler/lightningcss#671
Note, I had to reinstall some dependencies to fully get rid of it in the lockfile, that's why some indirect dependencies were bumped here as well.