Clean up diff header css and reduce global textarea min-height #29232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
silverwind
changed the title
silverwind
added
the
skip-changelog
zokkis
reviewed
Feb 18, 2024
| @@ -37,13 +37,13 @@ | |||
| .combo-markdown-editor textarea.markdown-text-editor { | |||
| display: block; | |||
| width: 100%; | |||
| min-height: 200px; | |||
| max-height: calc(100vh - 200px); | |||
| min-height: 140px; | |||
There was a problem hiding this comment.
looks like a magic number, maybe a css-var is easier to maintain and with the name of the var everybody knowns what the number means
There was a problem hiding this comment.
Added a per-element variable in 59230d2. Normally I do not recommend such variables because they complicate the themeing and I think all theme-related vars should be on :root, but it does make a certain sense to have "private" variables on elements like in this case.
There was a problem hiding this comment.
Actually I think a global variable makes sense here, added in ec7e053. The current 132px fits exactly 6 lines on my screen:
silverwind
changed the title
silverwind
commented
Feb 18, 2024
web_src/css/base.css
Outdated
| @@ -21,6 +21,7 @@ | |||
| --border-radius-circle: 50%; | |||
| --opacity-disabled: 0.55; | |||
| --height-loading: 16rem; | |||
| --min-height-textarea: 132px; | |||
There was a problem hiding this comment.
calc(1.57142em + 6lh + 2px) might be an alternative (padding + 6 lines + border), but lh unit is not so well supported: https://caniuse.com/?search=lh%20unit.
delvh
approved these changes
Feb 18, 2024
GiteaBot
added
lgtm/need 1
Co-authored-by: delvh <dev.lh@web.de>
silverwind
commented
Feb 18, 2024
denyskon
approved these changes
Feb 18, 2024
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Feb 20, 2024
…tea#29232) 1. Tweak diff header and remove a numbe of unneeded CSS for it: Before: <img width="433" alt="Screenshot 2024-02-18 at 01 08 09" src="https://github.com/go-gitea/gitea/assets/115237/d8b377c0-57bc-44d5-bb57-a582c7d4b3b4"> After: <img width="463" alt="Screenshot 2024-02-18 at 01 07 56" src="https://github.com/go-gitea/gitea/assets/115237/d08c17e7-5b86-4d07-81da-6371f4754325"> 3. Reduce height of review textarea and also reduce fomantic's CSS from 12em to 8em. Now fits better on my screen: <img width="1352" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/5c658d13-295e-4929-94da-13ade888020d"> --------- Co-authored-by: delvh <dev.lh@web.de>
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Feb 26, 2024
…tea#29232) 1. Tweak diff header and remove a numbe of unneeded CSS for it: Before: <img width="433" alt="Screenshot 2024-02-18 at 01 08 09" src="https://github.com/go-gitea/gitea/assets/115237/d8b377c0-57bc-44d5-bb57-a582c7d4b3b4"> After: <img width="463" alt="Screenshot 2024-02-18 at 01 07 56" src="https://github.com/go-gitea/gitea/assets/115237/d08c17e7-5b86-4d07-81da-6371f4754325"> 3. Reduce height of review textarea and also reduce fomantic's CSS from 12em to 8em. Now fits better on my screen: <img width="1352" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/5c658d13-295e-4929-94da-13ade888020d"> --------- Co-authored-by: delvh <dev.lh@web.de> (cherry picked from commit 39f8ab5)
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
