Remove jQuery class from the notification count

[yardenshoham]

• Switched from jQuery class functions to plain JavaScript classList
• Tested the notification count and it works as before

[wxiaoguang]

I guess it's better to introduce a util function:

queryElem('.notification_count', (el) => el.textContent = `${data.new}`);

I have seen too many loops for the refactoring.

[yardenshoham]

Maybe export

gitea/web_src/js/utils/dom.js

Line 3 in 849eee8

function elementsCall(el, func, ...args) {

?

[wxiaoguang]

Yup, it is a good candidate, meanwhile I guess it needs some rewriting and renaming.

[yardenshoham]

99d4ea3 (#30172)

Feel free to push here for nits

[silverwind]

I would name it forElems, e.g. do something for each matched element.

[silverwind]

Could also just use built-in methods, a bit more verbose but does the same:

Array.from(document.querySelectorAll('.foo')).forEach((el) => el.checked = true);

[silverwind]

Looks there is NodeList.forEach, so it can be shortened:

document.querySelectorAll('.foo').forEach((el) => el.checked = true);

@wxiaoguang @yardenshoham is that acceptable to you?

[yardenshoham]

Could also just use built-in methods

Lint converts it into a for-of loop.

Looks there is NodeList.forEach, so it can be shortened

Same here.

---

Honestly I think using a loop is OK, I don't see a big need to avoid it.

[silverwind]

Hmm yes the rule thinks it's Array.forEach because it has no type information and this is unfixable in the rule unless it gains type information from things like typescript's parser which we don't use yet.

So yes, I prefer revert to for-of now, even if it's more verbose.

[yardenshoham]

892cdc7