Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use httptest in integration tests #3080

Merged
merged 2 commits into from
Dec 3, 2017
Merged

Use httptest in integration tests #3080

merged 2 commits into from
Dec 3, 2017

Conversation

ethantkoenig
Copy link
Member

Use https://golang.org/pkg/net/http/httptest/ in integration tests instead of reinventing the wheel.

@codecov-io
Copy link

codecov-io commented Dec 3, 2017 •
edited
Loading

Codecov Report

Merging #3080 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3080   +/-   ##
=======================================
  Coverage   33.43%   33.43%           
=======================================
  Files         270      270           
  Lines       39595    39595           
=======================================
  Hits        13239    13239           
  Misses      24466    24466           
  Partials     1890     1890

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 993b866...c4db69f. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 3, 2017
@bkcsoft
Copy link
Member

bkcsoft commented Dec 3, 2017

Drone passes. LGTM 👍

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 3, 2017
@lafriks
Copy link
Member

lafriks commented Dec 3, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 3, 2017
@lafriks lafriks added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing labels Dec 3, 2017
@lafriks lafriks added this to the 1.4.0 milestone Dec 3, 2017
@lafriks lafriks merged commit e59adcd into go-gitea:master Dec 3, 2017
@ethantkoenig ethantkoenig deleted the update/integration_tests branch December 18, 2017 06:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ethantkoenig @codecov-io @bkcsoft @lafriks @tboerger