Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing memcache import #31105

Merged
merged 2 commits into from
May 27, 2024
Merged

Fix missing memcache import #31105

merged 2 commits into from
May 27, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 27, 2024 •
edited
Loading

Regression of #30417, the "memcache" import was not kept by mistake.

Fix #31102

@wxiaoguang wxiaoguang added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels May 27, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 27, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2024
@wxiaoguang wxiaoguang mentioned this pull request May 27, 2024
Closed
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 27, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 27, 2024
@silverwind
Copy link
Member

Needs a //nolint?

@wxiaoguang
Copy link
Contributor Author

Needs a //nolint?

Yup, force-pushed 1746b7e

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 27, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) May 27, 2024 13:15
@wxiaoguang wxiaoguang merged commit 20c4025 into go-gitea:main May 27, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone May 27, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 27, 2024
@wxiaoguang @GiteaBot
Fix missing memcache import (go-gitea#31105)
6fce266 
Fix go-gitea#31102
@GiteaBot GiteaBot mentioned this pull request May 27, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 27, 2024
wxiaoguang added a commit that referenced this pull request May 27, 2024
@GiteaBot @wxiaoguang
Fix missing memcache import (#31105) (#31109)
b0981f6 
Backport #31105 by wxiaoguang

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang wxiaoguang mentioned this pull request May 27, 2024
Closed
@wxiaoguang wxiaoguang deleted the fix-cache-memcache branch May 29, 2024 12:53
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

cache: unknown adapter 'memcache'(forgot to import?)
4 participants
@wxiaoguang @silverwind @lunny @GiteaBot