Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move custom tw- helpers to tailwind plugin #31184

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Move custom tw- helpers to tailwind plugin #31184

merged 3 commits into from
Jun 3, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 30, 2024 •
edited
Loading

Move the previous custom tw- classes to be defined in a tailwind plugin. I think it's cleaner that way and I also verified double-class works as expected:

Screenshot 2024-05-30 at 19 06 24

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 30, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2024
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 30, 2024
@silverwind silverwind changed the title Move custom tw- helpers to tailwind plugins Move custom tw- helpers to tailwind plugin May 30, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 3, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 3, 2024
@silverwind silverwind enabled auto-merge (squash) June 3, 2024 18:16
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 3, 2024
@silverwind silverwind merged commit 8c68c5e into go-gitea:main Jun 3, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 3, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 3, 2024
@silverwind silverwind deleted the twplug branch June 3, 2024 18:24
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 4, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e7da210 
* giteaofficial/main:
  Add option for mailer to override mail headers (go-gitea#27860)
  Move custom `tw-` helpers to tailwind plugin (go-gitea#31184)
  Remove unnecessary inline style for tab-size (go-gitea#31224)
  Document possible action types for the user activity feed API (go-gitea#31196)
  Remove sqlite-viewer and using database client (go-gitea#31223)
  Update golangci-lint to v1.59.0 (go-gitea#31221)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @techknowlogick @delvh @GiteaBot