Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return 500 if mirror url contains special chars #31859

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Don't return 500 if mirror url contains special chars #31859

merged 5 commits into from
Aug 21, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 18, 2024 •
edited
Loading

Fix #31640

@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Aug 18, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 18, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 18, 2024
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2024
@github-actions github-actions bot added the modifies/api This PR adds API routes or modifies them label Aug 18, 2024
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2024
@github-actions github-actions bot removed the modifies/api This PR adds API routes or modifies them label Aug 18, 2024
@yp05327
Copy link
Contributor

yp05327 commented Aug 19, 2024

Mirror also has the same problem in L242.

@lunny
Copy link
Member Author

lunny commented Aug 19, 2024

Mirror also has the same problem in L242.

d88d02e

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 21, 2024
@lunny lunny enabled auto-merge (squash) August 21, 2024 01:25
@GiteaBot
Copy link
Contributor

@lunny please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 21, 2024
@lunny lunny merged commit d158472 into go-gitea:main Aug 21, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 21, 2024
@lunny lunny deleted the lunny/fix_url_error branch August 21, 2024 02:36
lunny added a commit to lunny/gitea that referenced this pull request Aug 21, 2024
@lunny
Don't return 500 if mirror url contains special chars (go-gitea#31859)
6197e45 
Fix go-gitea#31640
@lunny lunny mentioned this pull request Aug 21, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Aug 21, 2024
lunny added a commit that referenced this pull request Aug 21, 2024
@lunny
Don't return 500 if mirror url contains special chars (#31859) (#31895)
e060ae8 
Backport #31859
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 24, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8a4eb2d 
* giteaofficial/main:
  Bump relative-time-element to v4.4.3 (go-gitea#31910)
  [skip ci] Updated translations via Crowdin
  Use correct function name (go-gitea#31887)
  Move lock icon position and add additional tooltips to branch list page (go-gitea#31839)
  Don't return 500 if mirror url contains special chars (go-gitea#31859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@yp05327 yp05327 yp05327 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

HTTP 500 error when adding push mirror with invalid character in URL
4 participants
@lunny @yp05327 @GiteaBot @Zettat123