Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for routers/repo/issue_label #3198

Merged
merged 2 commits into from
Dec 15, 2017

Conversation

ethantkoenig
Copy link
Member

Adds unit tests for routers/repo/issue_label.go. Also a little bit of refactoring to reuse test utility functions.

@codecov-io
Copy link

codecov-io commented Dec 15, 2017

Codecov Report

Merging #3198 into master will increase coverage by 0.37%.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3198      +/-   ##
==========================================
+ Coverage   34.51%   34.89%   +0.37%     
==========================================
  Files         276      277       +1     
  Lines       39975    39980       +5     
==========================================
+ Hits        13799    13951     +152     
+ Misses      24198    24015     -183     
- Partials     1978     2014      +36
Impacted Files Coverage Δ
routers/repo/issue.go 32.9% <0%> (+1%) ⬆️
modules/test/context_tests.go 0% <0%> (ø) ⬆️
routers/repo/issue_label.go 45.92% <100%> (+40.17%) ⬆️
modules/test/utils.go 100% <100%> (ø)
models/unit_tests.go 78.02% <30.76%> (-6.98%) ⬇️
models/repo_indexer.go 51.94% <0%> (-0.49%) ⬇️
models/repo.go 41.47% <0%> (+0.18%) ⬆️
models/repo_list.go 67.18% <0%> (+1.56%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bde0409...3199a6c. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 15, 2017
@sapk
Copy link
Member

sapk commented Dec 15, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 15, 2017
@lafriks lafriks added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing and removed type/bug labels Dec 15, 2017
@lafriks
Copy link
Member

lafriks commented Dec 15, 2017

Why did I add label bug? :)) LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 15, 2017
@lafriks lafriks merged commit befa744 into go-gitea:master Dec 15, 2017
@ethantkoenig ethantkoenig deleted the tests/issue_label branch December 16, 2017 04:39
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants