Git statistics in Activity tab

[lafriks]

Fixes #4697

TODO:

• Implement required methods to load data
• Git statistics display in Activity Tab
• UI cleanup
• Implement bar chart with top 10 users in UI (can be implemented in other PR)

Screenshot:

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

[codecov-io]

Codecov Report

Merging #4724 into master will increase coverage by 0.01%.
The diff coverage is 45%.

@@            Coverage Diff             @@
##           master    #4724      +/-   ##
==========================================
+ Coverage   41.23%   41.24%   +0.01%     
==========================================
  Files         421      422       +1     
  Lines       58125    58277     +152     
==========================================
+ Hits        23965    24037      +72     
- Misses      30989    31061      +72     
- Partials     3171     3179       +8

Impacted Files	Coverage Δ
models/repo_activity.go	52.21% <10%> (-14.07%)	⬇️
routers/routes/routes.go	82.39% <100%> (+0.09%)	⬆️
routers/repo/activity.go	40.35% <8%> (-24.36%)	⬇️
modules/git/repo_stats.go	84.5% <84.5%> (ø)
models/gpg_key.go	55.83% <0%> (-0.84%)	⬇️
routers/repo/view.go	43.03% <0%> (+1.01%)	⬆️
models/unit.go	67.56% <0%> (+5.4%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2933ae4...0d73090. Read the comment docs.

[sapk]

Works ans looks greats.
Just need to move calls to git command to go-gitea/git as it will ease the migration when fully switching to gopkg.in/src-d/go-git.v4. Another solution is to directly replace those calls by gopkg.in/src-d/go-git.v4.

[lafriks]

If anyone could point to method to do this with src-d/git I could rewrite this to use it

[lunny]

@sapk I think we need to move go-gitea/git back as a module of go-gitea/gitea. But we need keep all git codes as a well-formed sub package.

[lafriks]

@lunny @sapk please review

[sapk]

@lafriks LGTM but would be perfect with tests for new code under models and modules/git

[lafriks]

@sapk test added

[lunny]

It should be commits.

[lunny]

I think your code is right. But when some language's translation is missing, it will be replaced by English. And if on this language it's no difference between singular and plural. Then it will buggy. So we should know the real language before TrN called.

[lafriks]

@lunny it is only for untranslated strings for Chinese languages. For other it will be correct, and TrN function can not really know if it is untranslated or not. Anyway it is out of scope for this PR

[lunny]

That is out of this PR but it's still a problem.

[lafriks]

@lunny I agree but by currently uses i18n I don't see how that could be fixed

[ngourdon]

@lafriks
I cannot make a good translation of the messages in french.
Some parts of the message have singular and plural form (%d author(s), %d commit(s), ...) others don't (has pushed, have changed).

In french, I need to agree the verb with the grammatical number.

• 1 auteur a poussé
• 2 auteurs ont poussé

Depending on the verb, I think in english we have to as well.

• 1 author has pushed
• 2 authors have pushed

[lafriks]

Ok, I will try to split it out a bit more and add additional parts to be translatable depending on count

[mrsdizzie]

Maybe the words "has" and "have" could be removed and it would still have the same meaning without the problem above?

ie: 1 author pushed 1 commit, On Master 4 files changed. 2 authors pushed 2 commits ...

Maybe no need for has/have since "pushed" and "changed" already indicate past tense and work for both singular and plural? Not sure if that makes the translation any easier or not...

[ngourdon]

@mrsdizzie This will not make it any easier for french.

@lafriks
Only need to split the parts with verbs (has pushed, have changed)
Maybe we can join "%d author(s) pushed" and "%d file(s) changed" because the form of the verb depends on the subject.

[lafriks]

@ngourdon I have submitted PR #6848