Add inline comments on commits

[tonivj5]

Add comments on commits (not only in PR), I would love to have this feature 😃

Reference: #124, #124 (comment)

Thanks to gitea's team and contributors ❤️

[LukeOwlclaw]

Sorry, I don't want to be rude nor a smartass, I just want to understand. Is this issue about

Pull/Merge request inline comments

which is supposed to be already supported according to https://docs.gitea.io/en-us/comparison/ ?

[techknowlogick]

@LukeOwlclaw this issue is inline comments on commits. Inline comments on code in PRs already (per the docs you linked). also please take this comment same way, I'm a bit sleepy due to jetlag so I apologize if this response doesn't come off as friendly (I tried to make it friendly).

[rakshith-ravi]

@xxxTonixxx is there a PR that currently addresses this?

[tonivj5]

I think no 😢

[rakshith-ravi]

@techknowlogick I know open source projects hate asking for ETAs, and I really don't want to come off as rude, but I'm just curious how high on the priority list is this in? There doesn't seem to be a milestone listed, so what are the odds that we'll see this implemented in 1.7.x? Is this something the team is actively planning to work on or is it deferred for sometime later? Just curious so that I can set my expectations clear 😅

[techknowlogick]

@rakshith-ravi sadly it won’t be in 1.7 as we are a in a feature freeze for that release, as for ETAs I cant say, as for the project we don’t have a roadmap and things are added to the project as PRs happen. That means even a non-team member could work on this, if you or someone you know has Holland skills. As a side note you don’t come off as rude and I really appreciate how you asked as it was really kind :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[tonivj5]

Not yet, please 😢

[ghost]

Yeah this would be fantastic!

[6543]

Vote

[lunny]

So If we can comment on any commit. We should consider some implementation things below:

1. Where should the comments stored, currently all comments stored with an issue(pr)
2. We have to notify all related users(who?) via UI/mail and etc.

[rakshith-ravi]

I'd recommend a structure like this -
There would be two different kinds of comment on commits: One on the upstream code and one on the PR.

• Both the comment on commit can be linked to the repo (the repo ID as the primary key). That way, Even when the PR gets merged, the comment still stays. We could use a composite key of the commit hash and the repo ID as the primary key.
• As for the notification, we could perhaps notify all the users who are contributors of the repo. If it's a PR, I guess the PR owner will also be notified.

If I knew GoLang better, I would've implemented this myself. Unfortunately, I can only contribute in terms of software architecture

[zeripath]

I suspect we should leverage git notes or git notes-like behaviour for this. I suspect that putting this in to the database is only going to cause trouble. I wonder if the comments on PRs should do the same.

[zeripath]

@rakshith-ravi If you can program in an imperative language you can program in go. It's really not a very difficult language if you can get past its idiosyncrasies.

[lunny]

PR comments have been implemented. I think we are talking about commit comment without a PR.

[BaxAndrei]

Yes, like on github

[0x416c69]

Vote.

Gitea really lacks this important feature. Everything else I could live on without but not this.

[guillep2k]

@0x416c69 Just so I understand your use case, why comments are so important in a specific commit? I've seen GitHub has that, but I never could picture a proper scenario for this. Commits get quickly lost in the sea of blobs....

[BaxAndrei]

I use this function. Especially to signal to the people who sent the commit that something is wrong, exempting me from opening an issue. It is also useful if I want to add something extra to that commit or mention something.

[lunny]

We also need refactor notification system to notify via ui/mail/webhook and etc.

[0x416c69]

@guillep2k Best way possible for me to talk about a certain commit is the commit comment. Although I could just stick with a messenger and a group talk, place the commit link/hash and talk about it there with my team but it will get really messy and the track of the conversation will be lost very quickly.

As a basic and common user of git, this I think is the most needed feature.

[jcfigueiredo]

@0x416c69 Just so I understand your use case, why comments are so important in a specific commit? I've seen GitHub has that, but I never could picture a proper scenario for this. Commits get quickly lost in the see of blobs....

We use it a lot for code reviewing PRs before merging to master.

• 2ȼ

[techknowlogick]

@jcfigueiredo the review functionality already exists in PRs where you can comment on lines of code.

[Albirew]

this "may" also be useful to reference a commit or part of it to an issue without touching issue itself (examples: "may make issue #1 reappear", "this exact part breaks PR !2", etc.) or discussing about a specific part of code.

Again, these can already be done the other way around (eg:"commit b822518 may make this issue reappear", "the changes on modules/setting/queue.go lines 58-59 of commit c779ac1 breaks this PR", etc.)

[JLuc]

Also please allow to search commit comments.
It would then be possible to comment with keywords as "todo_documentation" or "done_documentation" so the documentation people manage and organise their work together along as the code evolves. This would also help prepare the detailed release news (shorter and not so technical version of the release logs).

[MOHHALIM]

It's a great feature to have as I had to take action items and comments in another document then share it with collaborators. It will be an upgrade to our experience.
Thanks gitea's team and contributors ❤️

[pinuke]

Even for forgetful programmers, this would be a blessed feature. I swear there are more instances where I forget what a piece of code does than actual files of source code that I have written in my life.

I could potentially solve this by writing summaries over my own code.

[bryanpedini]

@cknoll @ #4898 (comment)

Students create and maintain their code in a repo and the supervisor wants to comment on specific lines of code. Usually their is no workflow with pull requests.

IMHO students should first learn how to use proper management of their resources (know what an issue is, why it's filed, its purpose, when to close an issue, PRs and everything related, etc), and then learn git and apply their git knowledge on top of what they're already familiar with workflow-wise.
Again, just my 2c, but for me it would be kinda like giving a pilot the training on how to control the joke of a plane without explaining the reference manual, the non-normal checklists in case a problem arise, not telling them about the "mayday mayday mayday" call (or the less common non-strictly-emergency "pan pan pan" call), etc etc...

First give the fundations, then build on top.

[biju-ps]

+1 very useful feature

[MOHHALIM]

Hi Gitea's team and contributors ❤️,
Is this feature going to be available soon?

[cknoll]

@MOHHALIM As this is an Free Software Project: A more constructive question would be: What can we (as a community) do to get this feature implemented soon?

E.g. I just realized, that there is the possibility to support the work on open issues on bountysource: https://app.bountysource.com/teams/gitea

By searching for this issue here I accidentally created a new bounty:
https://app.bountysource.com/issues/63187881-add-inline-comments-on-commits (with currently one anonymous supporter, anonymously "promising" 50$ (probably this is some creation default and I have not figured out how I can change that). )

Also, there is the the possibility to sponsor this project (i.e. support in a not issue specific way).

[twisted-nematic57]

Like the LibreOffice folks say, "if you want a new feature you suggest it. Then either make it yourself or fund it".

[pinuke]

IMO, we're taking this GoFundMe thing too far. I get it. We all get it. Money doesn't grow on trees, but this is the open source community you guys are talking to. Money doesn't come from any of our pockets. This is the poor programmers club

GH issues is for contributors and users to work on features. Not electronically pan-handle each other.

Look I'm broke too, but this is just poorly representing the FOSS community (Emphasis on F OSS). The FOSS defacto standard for this is to just tell people "we're too broke to work on it right now," not "please give me money to do it"

[pinuke]

@KaKi87 That just makes it so much worse.

[pinuke]

Just so it's clear, these comments get sent out to subscribers through their emails. This means that this kind of behavior goes against the Github Acceptable Use Policy.

These kind of comments are also considerably off-topic which is also against multiple policies in the Acceptable Use Policies and GIthub Terms of Service. To find out what's on topic for GH Issues please see https://docs.github.com/en/issues/tracking-your-work-with-issues/about-issues

[KaKi87]

In which version ?

[delvh]

Erm… What?
I think you have slightly misunderstood what is meant by that, @oktasense.
It is meant as

not what you have posted.

And that is not yet supported.