Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default Pull Request Title #5735

Merged
merged 3 commits into from
Jan 16, 2019
Merged

Add Default Pull Request Title #5735

merged 3 commits into from
Jan 16, 2019

Conversation

eloyekunle
Copy link
Contributor

Set default PR title to commit summary if there's a single commit on the head branch, else set it to the head branch name
Fixes #3582.

Set default PR title to commit summary if there's a single commit on the head branch, else set it to the head branch name
@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c2dcb35). Click here to learn what that means.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5735   +/-   ##
=========================================
  Coverage          ?   37.76%           
=========================================
  Files             ?      325           
  Lines             ?    47695           
  Branches          ?        0           
=========================================
  Hits              ?    18014           
  Misses            ?    27085           
  Partials          ?     2596
Impacted Files Coverage Δ
routers/repo/pull.go 34.48% <81.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2dcb35...9dd63b2. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2019
If there's a single commit on the head branch, and it's multiline, then set it as the default PR description
@zeripath
Copy link
Contributor

@eloyekunle Could you just check that if users puts things like &amp; <script>console.log('oh dear')</script> etc in either the summary or the message that these are escaped with your patch. I can't run the code myself to check it at the moment.

@eloyekunle
Copy link
Contributor Author

@zeripath I've checked and it seems to escape fine.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 15, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Jan 15, 2019
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Jan 15, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 16, 2019
@jonasfranz jonasfranz merged commit 734834a into go-gitea:master Jan 16, 2019
@jonasfranz jonasfranz added the type/changelog Adds the changelog for a new Gitea version label Jan 16, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put latest commit title in the pull request to the title of the pull request
7 participants