Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI button clarification #5993

Closed
2 of 7 tasks
abulfatmasimov opened this issue Feb 7, 2019 · 7 comments
Closed
2 of 7 tasks

UI button clarification #5993

abulfatmasimov opened this issue Feb 7, 2019 · 7 comments
Labels
type/question Issue needs no code to be fixed, only a description on how to fix it yourself.

Comments

@abulfatmasimov
Copy link

  • Gitea version (or commit ref): 1.7.1
  • Git version: 2.18.1
  • Operating system: Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Can you please clarify what is this PR shortcut button for? Users complain that they get 404 when trying to create PR using this button. From the code, it looks like this button is only designed for PR from user's forked repository, but I could not find any description for this in the documentation.

Screenshots

screen shot 2019-02-07 at 12 42 24
@lunny lunny added the type/question Issue needs no code to be fixed, only a description on how to fix it yourself. label Feb 7, 2019
@jolheiser
Copy link
Member

Yes, that shortcut is for making PRs from a user's fork. From what I can tell, the button works the same whether clicked on the upstream repo or the forked repo.
Users will currently get a 404 if they click it and do not have a fork.

This PR should at least partially fix the issue.

@silverwind
Copy link
Member

GitHub had at some point in time a very similar green button, but they have since renamed it to "New Pull Request" and removed the green coloring. I think we should follow suit.

@jolheiser
Copy link
Member

GitHub had at some point in time a very similar green button, but they have since renamed it to "New Pull Request" and removed the green coloring. I think we should follow suit.

That is part of the planned list of UI updates in my PR #5980

@abulfatmasimov
Copy link
Author

IMHO, that button should be made inactive if does not meet those conditions (no fork, no upstream repo). This will make it better from UX perspective.

@jolheiser
Copy link
Member

GitHub's default action is to open a blank PR page, for reference.

@abulfatmasimov
Copy link
Author

Yes, this is exactly what majority of users would expect.

jolheiser added a commit to jolheiser/gitea that referenced this issue Feb 10, 2019
@jolheiser
Commit to reference related issues
1e7efd3 
Resolves go-gitea#5782
Resolves go-gitea#5861
Addresses original question in go-gitea#5993
techknowlogick pushed a commit that referenced this issue Feb 19, 2019
@jolheiser @techknowlogick
Minor UI tweaks (#5980)
d26d249 
* Remove all CommitStatus when a repo is deleted

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Minor UI tweaks (#5782)
Added 'No License' option
Added link and octicon change for external issue trackers
Reset password now notifies right away if the code is invalid

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* More UI tweaks
More info in PR

* Generate stylesheet for arc-green

* Make gofmt work

* Change PR integration since the button is changed

* Rebase

* Generate stylesheet

* UI updates
Made the PR button a "basic" button
Vertically centered the issue checkboxes
Labels will update only once after modal is closed

* Commit to reference related issues
Resolves #5782
Resolves #5861
Addresses original question in #5993

* Change the comment wording since PR button is no longer little and green.

* Revert changes that made Windows work

* Regenerate stylesheet

* Regenerate stylesheets

* make generate-stylesheets

* Update integration again, changed button style

Signed-off-by: jolheiser <john.olheiser@gmail.com>

* Added ID to PR button
Changed integration to use the ID to avoid breaking in the future

* Added missing semi-colons

* Added back distinction between issue actions and filters (overlooked it before)
Moved action button over next to other action dropdowns

* Remove extra tab formatting in list.tmpl

* Remove more formatting from GoLand

* Replace hardcoded "No License" with i18n license helper.
@techknowlogick
Copy link
Member

Closed per linked PR.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/question Issue needs no code to be fixed, only a description on how to fix it yourself.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lunny @silverwind @techknowlogick @jolheiser @abulfatmasimov