Minor UI tweaks

[jolheiser]

Behavior

• templates/repo/create.tmpl – Once you select a license you can no longer deselect it.
• External issue trackers: The issues tab should have an external-link-alt icon and link directly to the external tracker so that you can see the URL by hovering over it.
• When you select an issue/pull request the toggle button transitions to open & close buttons, which is not only problematic because it still looks like a toggle button but also doesn't make sense because you are never able to open or close an issue/pull request, it's either open or closed, you only ever have one choice (to toggle the current state). I suggest the transition to be removed and instead display an open or close button next to the toggle button.
  
• The above check boxes should not be displayed for repositories where you are not allowed to open or close issues/pull requests.
• 404 pages of files, issues, pull requests, releases and wiki pages should include the repository header if the repository exists.
• Reset password should directly tell you when a code is invalid: https://try.gitea.io/user/reset_password?code=x
• public/js/index.js – When editing the labels of an existing issue (see screenshot), the labels are currently saved with every select / deselect, which just leads to unnecessary spam. The labels should only be saved after closing the popup, which is also the way GitHub does it.
  

Visuals

• templates/repo/header.tmpl – Visually disable fork button on own repositories (you cannot clone them) by adding disabled class .
  
• templates/repo/home.tmpl – Give New Pull Request button a text label instead of a cryptic icon.
  
• public/less/themes/arc-green.less – The dark theme should use a less vibrant color for green buttons, I suggest #87ab63, the same color used for links.

[jolheiser]

As this is one of my first more in-depth PRs feel free to give me pointers along the way.

One thing I had a question about was, do the maintainers want all of the changes in one PR, or spread out into 2 (or 3)?

EDIT: Of course, my first run in with go fmt errors. I'll make sure to run the command for it next time I make changes.

[lunny]

CI failed

[silverwind]

Based on your screenshots, I think your fork is not up to date with some recent changes (button styles), please rebase the branch against master.

Regarding "New Pull Request" button, I'd say also remove the green color, making it plain grey.

[jolheiser]

I feel like the button is a little close, but acceptable.

When a user cannot create issues.

On a repo's home page, the Pull Request button is now in text (and on the other side).

If not on the home page, start displaying breadcrumb instead of PR button.

When a user encounters a 404 on any URL that would otherwise show a repo, the repo's header is displayed.

Disabled the fork button if the user cannot fork the repo.

[silverwind]

Good changes.

• Maybe add a basic class to the new pull request button. Personally, I find these grey buttons a bit ugly.
• The checkboxes on issues need vertical centering.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@2982413). Click here to learn what that means.
The diff coverage is 31.25%.

@@            Coverage Diff            @@
##             master    #5980   +/-   ##
=========================================
  Coverage          ?   38.85%           
=========================================
  Files             ?      352           
  Lines             ?    50045           
  Branches          ?        0           
=========================================
  Hits              ?    19445           
  Misses            ?    27784           
  Partials          ?     2816

Impacted Files	Coverage Δ
routers/user/auth.go	13.07% <0%> (ø)
modules/context/context.go	49.7% <100%> (ø)
modules/context/repo.go	59.29% <25%> (ø)
routers/repo/issue.go	36.42% <42.85%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2982413...e32153c. Read the comment docs.

[jolheiser]

Some new images with @silverwind's suggestions.

The new look of the PR button

Issue checkboxes vertically aligned

Issue labels should only update once after closing the modal. Currently it is storing all actions in a list and then looping over the list, updating the issue meta. It currently relies on the fact that adding a label to an issue that's already added (and vice-versa) doesn't update the label. I'm not sure I really like relying on that, however I thought I'd get second opinions on whether it's worth attempting to keep track of "new" actions for labels vs what they started as.

[kolaente]

Can you make the new pull request button the same height as the dropdown left to it? Also what about a color for said button?

And you need to regenerate stylesheets.

[jolheiser]

This PR is ready for review again. 😄

[techknowlogick]

Looking at code it looks good, I now just need to test it. One thing I am going to focus on testing is to ensure that for repos 404 it doesn’t show headers to users who don’t have permissions

[jolheiser]

Looking at code it looks good, I now just need to test it. One thing I am going to focus on testing is to ensure that for repos 404 it doesn’t show headers to users who don’t have permissions

That's a good point, I don't think I did anything specific for that, so it would be whether it happens earlier in the context.

EDIT: I wasn't able to get to a private repo if I was not signed in or not the owner. (Of course there are more checks I'm sure you will do, but it's a promising start.)

[0x5c]

Just to note that this PR fixes #5861 (#5782 being a meta-issue)

[techknowlogick]

In testing 404, I'm getting prompted for basic auth.

also when I successfully provide my credentials via basic auth it gives me the standard 404 without a header.

[jolheiser]

What an interesting thing. I cannot reproduce this in Chrome, as it returns a 401.
However, on Edge I was able to reproduce this.

Not sure on the browser side what is happening, but from Gitea's point of view that shouldn't be a valid URL...

Not sure if you want me to dig more into that (if I'm not mistaken, I think it's browser behavior), however testing with a URL similar to http://localhost:9090/tklk/blog/src/branch/master/404 should yield a 404 without a header if no permissions, or with a header if correct permissions.

[silverwind]

Browsers usually present these dialogs when they see a WWW-Authenticate response header, thought these should usually be only sent on a 401, not a 404.

[techknowlogick]

@jolheiser don't worry about it. I was able to replicate being prompted for basic auth in master and so it isn't something that your branch is adding. I have one or two more things I'm still testing, but hopefully I'll be done today.

[Aragur]

I think the more vibrant color in public/less/themes/arc-green.less was better.
As of now it looks kind of strange:

Googles Material Guidelines suggest using a vibrant color for action buttons.
Also a outlined button could be used. - Using the old vibrant color it would be less distracting.

[0x5c]

@AragurDEV Make an issue for it, and refer to this PR