-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change drone token name to let users know to use oauth2 #6912
Change drone token name to let users know to use oauth2 #6912
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6912 +/- ##
==========================================
- Coverage 41.42% 41.42% -0.01%
==========================================
Files 440 440
Lines 59738 59744 +6
==========================================
- Hits 24749 24747 -2
- Misses 31752 31760 +8
Partials 3237 3237
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm but I know nothing about Drone
Is this really only option? |
What users should be doing is using OAuth2, however some don't. So this will resolve the broken connection when they try to use basic auth with drone, however it'll let them know they should be using OAuth2. Basic auth connection with drone is already not working due with users that use 2FA, and so if users want to be secure they should be using OAuth2. And as we've seen from recent attacks against SCM providers, 2FA is essentially mandatory if you want to keep your code safe. I see this PR as temporary, and once 1.9.0 is final we can put in blog post that users should switch to OAuth2 for Drone, and then we can remove it for 1.10.0 |
But wouldn't generate lots of tokens this way? |
@lafriks yes, it would. This encourages users to switch to OAuth2 (basic auth for Gitea will be removed in next release of Drone) |
This changes the name of the drone token so that basic auth is still allowed (but points user in direction of using oauth2)