Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Branch View] [Bug] Restore Branch Button dont work #7569

Closed
6543 opened this issue Jul 22, 2019 · 13 comments
Closed

[Branch View] [Bug] Restore Branch Button dont work #7569

6543 opened this issue Jul 22, 2019 · 13 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@6543
Copy link
Member

6543 commented Jul 22, 2019 •
edited
Loading

The Restore Branch Button dont work on Firefox (Linux/68.0.1 x64)

testet on Gitea 1.10
@6543 6543 mentioned this issue Jul 22, 2019
Closed
14 tasks
@6543 6543 changed the title Restore Branch Button dont work [Branch View] Restore Branch Button dont work Jul 24, 2019
@6543 6543 changed the title [Branch View] Restore Branch Button dont work [Branch View] [Bug] Restore Branch Button dont work Jul 26, 2019
@6543

This comment has been minimized.

Sign in to view
@6543
Copy link
Member Author

6543 commented Jul 29, 2019 •
edited
Loading

http://localhost:3000/test/hometest/branches/restore?branch_id=22&name=merge-calcle produce page 404
is api brocken? (tested on firefox and chrome)

url was taken from "data-url" atribute of undo-button

@techknowlogick
Copy link
Member

It may 404 for GET requests, I believe it only accepts POST

@lunny
Copy link
Member

lunny commented Aug 1, 2019

Cannot reproduce on macOS Chrome and Firefox.

@gary-kim gary-kim mentioned this issue Aug 20, 2019
Merged
@6543
Copy link
Member Author

6543 commented Aug 25, 2019 •
edited
Loading

I'll test it on Windows and two different Linux systems today ...

EDIT: two diff Windows too

@6543
Copy link
Member Author

6543 commented Aug 25, 2019 •
edited
Loading

Version: 1.10.0+dev-210-gc9546d4cd

System Browser Worked Didn't
5.2.8-1-MANJARO Chrome 76 (64-Bit) x
5.2.8-1-MANJARO Chromium 76 (64-Bit) x
5.2.8-1-MANJARO Falkon 3.1.0 (QtWebEngine 5.13.0) x
5.2.8-1-MANJARO Firefox 68.0.1 (64-Bit) x
5.2.8-1-MANJARO Firefox Developer Ed. 69.0b12 (64-Bit) x
4.18.0-25-lowlatency Ubuntu Cosmic Firefox 68.0 (64-Bit) x
4.18.0-25-lowlatency Ubuntu Cosmic Chrome73 (64-Bit) x
Windows 8.1 Pro Firefox 62.0.3 (64-Bit) x
Windows 8.1 Pro Firefox 68.0.2 (64-Bit) x
Windows 10 Pro N Firefox 67.0.2 (64-Bit) x
Windows 10 Pro N Firefox 68.0.2 (64-Bit) x
Windows 10 Pro N Edge 42 x
Android 9 Fennec F-Droid 68.0 x
Android 9 Tor Browser 60.8.0 x
Android 9 Lightning 4.5.1 x

@6543
Copy link
Member Author

6543 commented Aug 25, 2019 •
edited
Loading

so only Firefox Linux versions and one Windows Firefox combi has problems with this :(

-> cant test Max OSX so if somebody can do this ...

EDIT: @lunny can you add detailed information of your OSX test?

@6543
Copy link
Member Author

6543 commented Aug 28, 2019

it realy looks like Linux + Firefox dont open the link as POST but as GET request!

@lunny
Copy link
Member

lunny commented Aug 28, 2019 •
edited
Loading

System Browser Worked Didn't
macOS 10.14.5 Chrome 76 (64-Bit) x
macOS 10.14.5 Firefox 68 (64-Bit) x
macOS 10.14.5 Safari 12.1.1 (64-Bit) x

@6543
Copy link
Member Author

6543 commented Oct 6, 2019

tested with current version 8a82850

System: Linux 5.2 | Manjaro | Firefox 69.0.1 (64-Bit)

result: still exist

@stale
Copy link

stale bot commented Dec 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Dec 5, 2019
@6543
Copy link
Member Author

6543 commented Dec 5, 2019

tested with e80fe20 still exist :(

@stale stale bot removed the issue/stale label Dec 5, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Dec 5, 2019
@6543
Copy link
Member Author

6543 commented Jan 2, 2020

gone with fomantic 👍

@6543 6543 closed this as completed Jan 2, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lunny @techknowlogick @lafriks @6543