Closing issues keywords should be configurable

[guillep2k]

• Gitea version (or commit ref): v1.9
• Git version: -
• Operating system: -
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Issue close keywords should be translated. Perhaps parsed according to the PR creator's language.

See models/action.go issueCloseKeywords

[techknowlogick]

We have WIP keywords be configurable via app.ini, perhaps something similar for close keywords?

(Edit: please note this is just a suggestion, and not saying this is 100% the way it should be done)

Another way would be to add close keywords to translation files and reference those?

[guillep2k]

Using the translation files sounds more like the Gitea way.

The goal of this project is to provide the easiest, fastest, and most painless way of setting up a self-hosted Git service.

😊

[lunny]

@guillep2k This should not be on translation file but follow WIP keywords. For Chinese we prefer close the issue via all these keywords close,closed,fix,fixed,resolve,resolved,关闭,修复,解决. A configuration item is better I think.

[guillep2k]

I have no problem of going with a setting for this particular case.

[guillep2k]

Thinking about it a little further, using translations will introduce a breaking change every time the translations are updated, so a setting is much better in that regard.

[sapk]

For an other PR, what about adding a advanced part at the installation page allowing to auto setup specific local config and filled them from translation file?

[guillep2k]

@sapk Sounds nice. We should make a TODO list of features to implement on that page.