Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy Policy and Terms of Service Page #9513

Merged
merged 46 commits into from
Jan 14, 2020

Conversation

bagasme
Copy link
Contributor

@bagasme bagasme commented Dec 27, 2019

Both legal pages are implemented in static HTML, located in public/privacy.html and public/tos.html, respectively.

Currently uses lorem ipsum texts, which will be replaced by real legal code / clauses. Please add more commits here to add them (legal code).

This will close #8353.

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 27, 2019
@lafriks
Copy link
Member

lafriks commented Dec 27, 2019

I don't think no one here has legal background to update these texts, I would prefer that everything would be moved to contrib (static sample file) and add section in docs to describe how to add this. Translations can be left tho

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 27, 2019
@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #9513 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9513      +/-   ##
=========================================
- Coverage   42.31%   42.3%   -0.01%     
=========================================
  Files         599     599              
  Lines       78330   78330              
=========================================
- Hits        33145   33138       -7     
- Misses      41131   41138       +7     
  Partials     4054    4054
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 38.59% <0%> (-0.88%) ⬇️
models/gpg_key.go 55.03% <0%> (-0.56%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da3ffe6...b251457. Read the comment docs.

@zeripath
Copy link
Contributor

I think it would be better to start from this: https://gdpr.eu/wp-content/uploads/2019/01/Our-Company-Privacy-Policy.pdf instead of lorem ipsum dolorum.

In reality the vast majority of gitea installs will follow the same pattern so, if we can get the boilerplate right for a default install then most people should never need to change it.

Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge per @lafriks feedback

@bagasme
Copy link
Contributor Author

bagasme commented Dec 28, 2019

@lafriks So basically you proposed like adding extra links?

@bagasme
Copy link
Contributor Author

bagasme commented Dec 29, 2019

Thanks for suggestion @lafriks

@bagasme bagasme changed the title Add Privacy Policy and Terms of Service Page [WIP] Add Privacy Policy and Terms of Service Page Dec 30, 2019
@bagasme
Copy link
Contributor Author

bagasme commented Dec 31, 2019

@techknowlogick @lafriks done

@bagasme bagasme changed the title [WIP] Add Privacy Policy and Terms of Service Page Add Privacy Policy and Terms of Service Page Dec 31, 2019
@sapk sapk added the type/docs This PR mainly updates/creates documentation label Jan 2, 2020
Co-Authored-By: Antoine GIRARD <sapk@users.noreply.github.com>
@bagasme
Copy link
Contributor Author

bagasme commented Jan 4, 2020

For milestone, I expect this PR to be merged for 1.11 or 1.12.

@techknowlogick
Copy link
Member

@bagasme as this is a docs PR that doesn't apply to a specific version it can be merged as soon as it is approved without milestone.

@bagasme
Copy link
Contributor Author

bagasme commented Jan 4, 2020

@techknowlogick so can this PR be merged soon?

@techknowlogick
Copy link
Member

@bagasme yes, once two LG-TM given, and no pending requested changes.

@techknowlogick techknowlogick dismissed their stale review January 4, 2020 10:06

dismiss review

@zeripath
Copy link
Contributor

zeripath commented Jan 6, 2020

@go-gitea/owners I think this one could do with a final sign-off.

This is a good start, however, we will likely need to make some clarifications in the docs pages - as it could be interpreted that all gitea instances use third-party resources and/or that the only way to have a compliant Gitea is to host it on its own multisite server racks with full disk encryption etc.

@sapk
Copy link
Member

sapk commented Jan 7, 2020

I think the next step would be to build a file generator outside gitea (or a plugin 😄) depending on question (instance name, resonse time, third party, ...) that the user would deploy the result on their instance.

Gitea source code ships with sample pages, available in `contrib/legal` directory. Copy them to `custom/public/`. For example, to add Privacy Policy:

```
cp $GOPATH/src/code.gitea.io/gitea/contrib/legal/privacy.html.sample /path/to/custom/public/privacy.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would replace this with the online link

Copy link
Contributor Author

@bagasme bagasme Jan 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@6543 did you mean replacing this cp line with following?:

Suggested change
cp $GOPATH/src/code.gitea.io/gitea/contrib/legal/privacy.html.sample /path/to/custom/public/privacy.html
wget -O /path/to/custom/public/privacy.html https://raw.githubusercontent.com/go-gitea/gitea/master/contrib/legal/privacy.html.sample

Create or append to footer template

Co-Authored-By: 6543 <6543@obermui.de>
@6543 suggest replacing this `cp` line (which assumed that Gitea sources are available) with `wget` to GitHub raw link. At the time of writing this, this returned 404, but when this PR has been merged, this should get the actual page.
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smal nit

1. Add gpg key to profile information
2. Add Git repos to list of User Personal Information
3. Comment out responsibility for sensitive information

Co-Authored-By: 6543 <6543@obermui.de>
@bagasme bagasme requested a review from 6543 January 8, 2020 10:48
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@6543
Copy link
Member

6543 commented Jan 8, 2020

there is law support for open source but i dont have the connections ...

maby somebody can wirte someone on mastodnon ...

@sapk sapk merged commit ce274d6 into go-gitea:master Jan 14, 2020
@bagasme bagasme deleted the new/privacy-policy-tos branch January 17, 2020 03:31
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Privacy Policy and Terms of Service Page
9 participants