-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Privacy Policy and Terms of Service Page #9513
Conversation
I don't think no one here has legal background to update these texts, I would prefer that everything would be moved to contrib (static sample file) and add section in docs to describe how to add this. Translations can be left tho |
Codecov Report
@@ Coverage Diff @@
## master #9513 +/- ##
=========================================
- Coverage 42.31% 42.3% -0.01%
=========================================
Files 599 599
Lines 78330 78330
=========================================
- Hits 33145 33138 -7
- Misses 41131 41138 +7
Partials 4054 4054
Continue to review full report at Codecov.
|
I think it would be better to start from this: https://gdpr.eu/wp-content/uploads/2019/01/Our-Company-Privacy-Policy.pdf instead of lorem ipsum dolorum. In reality the vast majority of gitea installs will follow the same pattern so, if we can get the boilerplate right for a default install then most people should never need to change it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking merge per @lafriks feedback
@lafriks So basically you proposed like adding extra links? |
The document is inspired from GitHub.
Thanks for suggestion @lafriks |
Adapted from GitHub
@techknowlogick @lafriks done |
Co-Authored-By: Antoine GIRARD <sapk@users.noreply.github.com>
For milestone, I expect this PR to be merged for 1.11 or 1.12. |
@bagasme as this is a docs PR that doesn't apply to a specific version it can be merged as soon as it is approved without milestone. |
@techknowlogick so can this PR be merged soon? |
@bagasme yes, once two LG-TM given, and no pending requested changes. |
@go-gitea/owners I think this one could do with a final sign-off. This is a good start, however, we will likely need to make some clarifications in the docs pages - as it could be interpreted that all gitea instances use third-party resources and/or that the only way to have a compliant Gitea is to host it on its own multisite server racks with full disk encryption etc. |
I think the next step would be to build a file generator outside gitea (or a plugin 😄) depending on question (instance name, resonse time, third party, ...) that the user would deploy the result on their instance. |
Gitea source code ships with sample pages, available in `contrib/legal` directory. Copy them to `custom/public/`. For example, to add Privacy Policy: | ||
|
||
``` | ||
cp $GOPATH/src/code.gitea.io/gitea/contrib/legal/privacy.html.sample /path/to/custom/public/privacy.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would replace this with the online link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@6543 did you mean replacing this cp
line with following?:
cp $GOPATH/src/code.gitea.io/gitea/contrib/legal/privacy.html.sample /path/to/custom/public/privacy.html | |
wget -O /path/to/custom/public/privacy.html https://raw.githubusercontent.com/go-gitea/gitea/master/contrib/legal/privacy.html.sample |
Create or append to footer template Co-Authored-By: 6543 <6543@obermui.de>
@6543 suggest replacing this `cp` line (which assumed that Gitea sources are available) with `wget` to GitHub raw link. At the time of writing this, this returned 404, but when this PR has been merged, this should get the actual page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smal nit
1. Add gpg key to profile information 2. Add Git repos to list of User Personal Information 3. Comment out responsibility for sensitive information Co-Authored-By: 6543 <6543@obermui.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
there is law support for open source but i dont have the connections ... maby somebody can wirte someone on mastodnon ... |
Both legal pages are implemented in static HTML, located in
public/privacy.html
andpublic/tos.html
, respectively.Currently uses lorem ipsum texts, which will be replaced by real legal code / clauses. Please add more commits here to add them (legal code).
This will close #8353.