Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stale message #9920

Merged
merged 5 commits into from
Jan 22, 2020
Merged

Improve stale message #9920

merged 5 commits into from
Jan 22, 2020

Conversation

sapk
Copy link
Member

@sapk sapk commented Jan 21, 2020

Some users are irritated by the stale bot.

We can maybe improve the message to help understand the goal and how it works.

@sapk sapk added type/miscellaneous skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 21, 2020
@sapk sapk changed the title Improve stale nessage Improve stale message Jan 21, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 21, 2020
@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

Merging #9920 into master will decrease coverage by 0.01%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9920      +/-   ##
==========================================
- Coverage   42.29%   42.28%   -0.02%     
==========================================
  Files         607      608       +1     
  Lines       79352    79392      +40     
==========================================
+ Hits        33561    33568       +7     
- Misses      41649    41681      +32     
- Partials     4142     4143       +1
Impacted Files Coverage Δ
services/pull/commit_status.go 5.19% <0%> (-2.97%) ⬇️
services/gitdiff/gitdiff.go 66.36% <0%> (ø) ⬆️
routers/repo/pull.go 28.67% <0%> (-0.07%) ⬇️
models/commit_status.go 64.13% <100%> (-2.2%) ⬇️
routers/api/v1/repo/status.go 44.57% <50%> (ø) ⬆️
modules/structs/commit_status.go 54.54% <54.54%> (ø)
models/repo.go 49.76% <0%> (-0.14%) ⬇️
services/pull/patch.go 67.92% <0%> (ø) ⬆️
routers/repo/view.go 39.47% <0%> (+0.87%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b246dfe...32c89e9. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2020
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit.

.github/stale.yml Outdated Show resolved Hide resolved
sapk and others added 2 commits January 22, 2020 02:29
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
@lafriks lafriks merged commit eed3616 into go-gitea:master Jan 22, 2020
@sapk sapk deleted the stale-msg branch January 22, 2020 11:23
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants