Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize credentials in mirror form #9975

Merged
merged 2 commits into from
Jan 25, 2020
Merged

Sanitize credentials in mirror form #9975

merged 2 commits into from
Jan 25, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 25, 2020

Fix #7431

@lunny lunny added this to the 1.12.0 milestone Jan 25, 2020
@codecov-io
Copy link

codecov-io commented Jan 25, 2020 •
edited
Loading

Codecov Report

Merging #9975 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9975      +/-   ##
==========================================
- Coverage   42.28%   42.27%   -0.01%     
==========================================
  Files         610      610              
  Lines       80370    80370              
==========================================
- Hits        33981    33976       -5     
- Misses      42206    42212       +6     
+ Partials     4183     4182       -1
Impacted Files Coverage Δ
services/pull/temp_repo.go 31.62% <0%> (-2.57%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
models/gpg_key.go 54.81% <0%> (-0.56%) ⬇️
modules/queue/workerpool.go 41.2% <0%> (+1.28%) ⬆️
services/pull/patch.go 67.92% <0%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f413f...4a82be8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 25, 2020
@zeripath zeripath changed the title fix wrong mirror from fix wrong mirror form Jan 25, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 25, 2020
silverwind
silverwind reviewed Jan 25, 2020
View reviewed changes
modules/util/sanitize_test.go
"https://mytoken@github.com/go-gitea/test_repo.git": "https://github.com/go-gitea/test_repo.git",
"http://github.com/go-gitea/test_repo.git": "http://github.com/go-gitea/test_repo.git",
"/test/repos/repo1": "/test/repos/repo1",
"git@github.com:go-gitea/test_repo.git": "(unparsable url)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test for ""?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 25, 2020
@zeripath zeripath merged commit a67c06c into go-gitea:master Jan 25, 2020
@zeripath zeripath changed the title fix wrong mirror form Sanitize credentials in mirror form Jan 25, 2020
@lunny lunny deleted the lunny/fix_mirror_from branch January 26, 2020 04:35
lunny added a commit to lunny/gitea that referenced this pull request Jan 26, 2020
@lunny
Sanitize credentials in mirror form (go-gitea#9975)
469c955
@lunny lunny mentioned this pull request Jan 26, 2020
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jan 26, 2020
zeripath pushed a commit that referenced this pull request Jan 26, 2020
@lunny @zeripath
Sanitize credentials in mirror form (#9975) (#9991)
16dfd9f
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Forked from a mirror and create a branch, compare view should hide create PR button
5 participants
@lunny @codecov-io @silverwind @zeripath @GiteaBot