Make Ctrl+Enter (quick submit) work for issue comment and wiki editor #19729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… quick submit) means "comment"
delvh
reviewed
May 16, 2022
GiteaBot
added
the
lgtm/need 2
wxiaoguang
force-pushed
the
fix-ctrl-enter
branch
from
afd5fa1
to
91f23cd
Compare
|
Updated. And add |
This comment was marked as off-topic.
This comment was marked as off-topic.
lunny
added
type/enhancement
delvh
approved these changes
May 17, 2022
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 18, 2022
GiteaBot
added
lgtm/done
|
🚀 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 20, 2022
* giteaofficial/main: Move org functions (go-gitea#19753) [doctor] pq: syntax error at or near "." quote user table name (go-gitea#19765) [doctor] update the help with fix capabilities (go-gitea#19762) Remove fomantic progress module (go-gitea#19760) Make Ctrl+Enter (quick submit) work for issue comment and wiki editor (go-gitea#19729) Enable packages by default again (as described by docs) (go-gitea#19746) Replace blue button and label classes with primary (go-gitea#19763) Fix org package owner permissions (go-gitea#19742)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
…go-gitea#19729) * Make Ctrl+Enter (quick submit) work for issue comment and wiki editor * Remove the required `SubmitReviewForm.Type`, empty type (triggered by quick submit) means "comment" * Merge duplicate code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a more general method to handle quick submit (Ctrl+Enter or Cmd+Enter).
With this PR, the editor for
Edit Commentcan respond to quick submit (which didn't before)Partially fixes:
Then all the forms mentions in #14843 can be improved to benefit the quick submit after this PR.
This PR also removes the required
SubmitReviewForm.Typecheck, now empty type (triggered by quick submit) means "comment".